Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dc0dfc10 authored by Nataniel Borges's avatar Nataniel Borges
Browse files

Fix linter issues 

Bug: 217777115
Bug: 197726610
Bug: 246284124
Bug: 240918620
Fixes: 273944864
Test: atest FlickerTests WMShellFlickerTests
Change-Id: I26b2d7f6d706447b7a0bde405e0559f83eecd615
parent a691318b

libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/pip/AutoEnterPipOnGoToHomeTest.kt

+1 −0
Original line number Diff line number Diff line
@@ -40,6 +40,7 @@ import org.junit.runners.Parameterized 
 *     Select "Auto-enter PiP" radio button

 *     Press Home button or swipe up to go Home and put [pipApp] in pip mode

 * ```

 *

 * Notes:

 * ```

 *     1. All assertions are inherited from [EnterPipTest]

libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/pip/ClosePipBySwipingDownTest.kt

+1 −0
Original line number Diff line number Diff line
@@ -38,6 +38,7 @@ import org.junit.runners.Parameterized 
 *     Launch an app in pip mode [pipApp],

 *     Swipe the pip window to the bottom-center of the screen and wait it disappear

 * ```

 *

 * Notes:

 * ```

 *     1. Some default assertions (e.g., nav bar, status bar and screen covered)

libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/pip/ClosePipWithDismissButtonTest.kt

+1 −0
Original line number Diff line number Diff line
@@ -38,6 +38,7 @@ import org.junit.runners.Parameterized 
 *     Click on the pip window

 *     Click on dismiss button and wait window disappear

 * ```

 *

 * Notes:

 * ```

 *     1. Some default assertions (e.g., nav bar, status bar and screen covered)

libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/pip/EnterPipToOtherOrientation.kt

+1 −0
Original line number Diff line number Diff line
@@ -53,6 +53,7 @@ import org.junit.runners.Parameterized 
 *     Launch [pipApp] on a fixed landscape orientation

 *     Broadcast action [ACTION_ENTER_PIP] to enter pip mode

 * ```

 *

 * Notes:

 * ```

 *     1. Some default assertions (e.g., nav bar, status bar and screen covered)

libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/pip/EnterPipTransition.kt

+2 −8
Original line number Diff line number Diff line
@@ -44,9 +44,7 @@ abstract class EnterPipTransition(flicker: FlickerTest) : PipTransition(flicker) 
    @Presubmit

    @Test

    open fun pipAppLayerAlwaysVisible() {

        flicker.assertLayers {

            this.isVisible(pipApp)

        }

        flicker.assertLayers { this.isVisible(pipApp) }

    }



    /** Checks the content overlay appears then disappears during the animation */
@@ -55,11 +53,7 @@ abstract class EnterPipTransition(flicker: FlickerTest) : PipTransition(flicker) 
    open fun pipOverlayLayerAppearThenDisappear() {

        val overlay = ComponentNameMatcher.PIP_CONTENT_OVERLAY

        flicker.assertLayers {

            this.notContains(overlay)

                .then()

                .contains(overlay)

                .then()

                .notContains(overlay)

            this.notContains(overlay).then().contains(overlay).then().notContains(overlay)

        }

    }