Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dbc84f80 authored by Yuri Lin's avatar Yuri Lin
Browse files

Remove Tron (MetricsLogger) logging from RemoteInputView. 

This logging was duplicated by Westworld UiEvent logging in ag/14341502, and confirmed that these events are properly getting logged, and aggregated tron logs haven't been kept since 2019.

Test: atest RemoteInputViewTest
Fixes: 159697717
Change-Id: I0f924ce6a9dd33d696ab220a35f8af4f52d999d2
parent 9f9016ea

packages/SystemUI/src/com/android/systemui/statusbar/policy/RemoteInputView.java

+0 −10
Original line number Diff line number Diff line
@@ -75,10 +75,8 @@ import android.widget.TextView; 
import androidx.annotation.NonNull;



import com.android.internal.graphics.ColorUtils;

import com.android.internal.logging.MetricsLogger;

import com.android.internal.logging.UiEvent;

import com.android.internal.logging.UiEventLogger;

import com.android.internal.logging.nano.MetricsProto;

import com.android.internal.statusbar.IStatusBarService;

import com.android.internal.util.ContrastColorUtil;

import com.android.systemui.Dependency;
@@ -413,8 +411,6 @@ public class RemoteInputView extends LinearLayout implements View.OnClickListene 
                mEntry.getSbn().getPackageName(),

                mEntry.getSbn().getUser().getIdentifier());



        MetricsLogger.action(mContext, MetricsProto.MetricsEvent.ACTION_REMOTE_INPUT_SEND,

                mEntry.getSbn().getPackageName());

        mUiEventLogger.logWithInstanceId(

                NotificationRemoteInputEvent.NOTIFICATION_REMOTE_INPUT_SEND,

                mEntry.getSbn().getUid(), mEntry.getSbn().getPackageName(),
@@ -423,8 +419,6 @@ public class RemoteInputView extends LinearLayout implements View.OnClickListene 
            mPendingIntent.send(mContext, 0, intent);

        } catch (PendingIntent.CanceledException e) {

            Log.i(TAG, "Unable to send remote input result", e);

            MetricsLogger.action(mContext, MetricsProto.MetricsEvent.ACTION_REMOTE_INPUT_FAIL,

                    mEntry.getSbn().getPackageName());

            mUiEventLogger.logWithInstanceId(

                    NotificationRemoteInputEvent.NOTIFICATION_REMOTE_INPUT_FAILURE,

                    mEntry.getSbn().getUid(), mEntry.getSbn().getPackageName(),
@@ -500,8 +494,6 @@ public class RemoteInputView extends LinearLayout implements View.OnClickListene 
        mRemoteInputQuickSettingsDisabler.setRemoteInputActive(false);



        if (logClose) {

            MetricsLogger.action(mContext, MetricsProto.MetricsEvent.ACTION_REMOTE_INPUT_CLOSE,

                    mEntry.getSbn().getPackageName());

            mUiEventLogger.logWithInstanceId(

                    NotificationRemoteInputEvent.NOTIFICATION_REMOTE_INPUT_CLOSE,

                    mEntry.getSbn().getUid(), mEntry.getSbn().getPackageName(),
@@ -582,8 +574,6 @@ public class RemoteInputView extends LinearLayout implements View.OnClickListene 
    }



    public void focus() {

        MetricsLogger.action(mContext, MetricsProto.MetricsEvent.ACTION_REMOTE_INPUT_OPEN,

                mEntry.getSbn().getPackageName());

        mUiEventLogger.logWithInstanceId(

                NotificationRemoteInputEvent.NOTIFICATION_REMOTE_INPUT_OPEN,

                mEntry.getSbn().getUid(), mEntry.getSbn().getPackageName(),