Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dba7d914 authored by Ioana Alexandru's avatar Ioana Alexandru
Browse files

[Notif redesign] Change color of conversation icon bg 

We were using the same circle drawable for the conversation icon as we
do for the small icon, in order to crop conversation icons to a circle.

However, for the small icon we generally apply a color to this drawable,
so in that case the default color (a dark grey) didn't really matter.
In the case of conversations though, we can have conversation icons with
a transparent background, which lead to the dark grey circle showing
behind. This looked okay in dark mode, but not in light mode, so this
change introduces a new background drawable with a semi-transparent
color that looks good in any theme.

Fix: 406224300
Test: manual, receive a Gmail space notification and check that it looks good in both normal conversations and minimal HUNs, with dark mode on and off
Flag: android.app.notifications_redesign_templates
Change-Id: I7caf1c930c708fc048175a2864ece1665f81475a
parent 7b9cf5ac

core/res/res/drawable/notification_2025_conversation_icon_background.xml

0 → 100644
+19 −0
Original line number Diff line number Diff line 
<?xml version="1.0" encoding="utf-8"?>

<!-- Copyright (C) 2025 The Android Open Source Project



     Licensed under the Apache License, Version 2.0 (the "License");

     you may not use this file except in compliance with the License.

     You may obtain a copy of the License at



          http://www.apache.org/licenses/LICENSE-2.0



     Unless required by applicable law or agreed to in writing, software

     distributed under the License is distributed on an "AS IS" BASIS,

     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

     See the License for the specific language governing permissions and

     limitations under the License.

-->



<shape xmlns:android="http://schemas.android.com/apk/res/android" android:shape="oval">

    <solid android:color="#26FFFFFF" />

</shape>

core/res/res/layout/notification_2025_conversation_icon_container.xml

+1 −1
Original line number Diff line number Diff line
@@ -40,7 +40,7 @@ 
            android:id="@+id/conversation_icon"

            android:layout_width="@dimen/notification_2025_icon_circle_size"

            android:layout_height="@dimen/notification_2025_icon_circle_size"

            android:background="@drawable/notification_icon_circle"

            android:background="@drawable/notification_2025_conversation_icon_background"

            android:clipToOutline="true"

            android:scaleType="centerCrop"

            android:importantForAccessibility="no"

core/res/res/layout/notification_2025_template_compact_heads_up_messaging.xml

+1 −1
Original line number Diff line number Diff line
@@ -41,7 +41,7 @@ 
        android:layout_height="@dimen/notification_icon_circle_size"

        android:layout_gravity="center_vertical|start"

        android:layout_marginStart="@dimen/notification_icon_circle_start"

        android:background="@drawable/notification_icon_circle"

        android:background="@drawable/notification_2025_conversation_icon_background"

        android:clipToOutline="true"

        android:maxDrawableWidth="@dimen/notification_icon_circle_size"

        android:maxDrawableHeight="@dimen/notification_icon_circle_size"