Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db7423cd authored by Alan Viverette's avatar Alan Viverette
Browse files

Automatic casts for more findViewById implementations 

Bug: 24137209
Test: make -j32
Change-Id: I423297a78e63d74eb44fd14747fc3890a9c42937
parent 36db127e

api/current.txt

+3 −3
Original line number Original line Diff line number Diff line
@@ -3578,7 +3578,7 @@ package android.app { 
    method public void dump(java.lang.String, java.io.FileDescriptor, java.io.PrintWriter, java.lang.String[]);

    method public void dump(java.lang.String, java.io.FileDescriptor, java.io.PrintWriter, java.lang.String[]);

    method public void enterPictureInPictureMode();

    method public void enterPictureInPictureMode();

    method public boolean enterPictureInPictureMode(android.app.PictureInPictureArgs);

    method public boolean enterPictureInPictureMode(android.app.PictureInPictureArgs);

    method public android.view.View findViewById(int);

    method public <T extends android.view.View> T findViewById(int);

    method public void finish();

    method public void finish();

    method public void finishActivity(int);

    method public void finishActivity(int);

    method public void finishActivityFromChild(android.app.Activity, int);

    method public void finishActivityFromChild(android.app.Activity, int);
@@ -4358,7 +4358,7 @@ package android.app { 
    method public boolean dispatchPopulateAccessibilityEvent(android.view.accessibility.AccessibilityEvent);

    method public boolean dispatchPopulateAccessibilityEvent(android.view.accessibility.AccessibilityEvent);

    method public boolean dispatchTouchEvent(android.view.MotionEvent);

    method public boolean dispatchTouchEvent(android.view.MotionEvent);

    method public boolean dispatchTrackballEvent(android.view.MotionEvent);

    method public boolean dispatchTrackballEvent(android.view.MotionEvent);

    method public android.view.View findViewById(int);

    method public <T extends android.view.View> T findViewById(int);

    method public android.app.ActionBar getActionBar();

    method public android.app.ActionBar getActionBar();

    method public final android.content.Context getContext();

    method public final android.content.Context getContext();

    method public android.view.View getCurrentFocus();

    method public android.view.View getCurrentFocus();
@@ -46538,7 +46538,7 @@ package android.view { 
    method public void clearFlags(int);

    method public void clearFlags(int);

    method public abstract void closeAllPanels();

    method public abstract void closeAllPanels();

    method public abstract void closePanel(int);

    method public abstract void closePanel(int);

    method public android.view.View findViewById(int);

    method public <T extends android.view.View> T findViewById(int);

    method public boolean getAllowEnterTransitionOverlap();

    method public boolean getAllowEnterTransitionOverlap();

    method public boolean getAllowReturnTransitionOverlap();

    method public boolean getAllowReturnTransitionOverlap();

    method public final android.view.WindowManager.LayoutParams getAttributes();

    method public final android.view.WindowManager.LayoutParams getAttributes();

api/system-current.txt

+3 −3
Original line number Original line Diff line number Diff line
@@ -3702,7 +3702,7 @@ package android.app { 
    method public void dump(java.lang.String, java.io.FileDescriptor, java.io.PrintWriter, java.lang.String[]);

    method public void dump(java.lang.String, java.io.FileDescriptor, java.io.PrintWriter, java.lang.String[]);

    method public void enterPictureInPictureMode();

    method public void enterPictureInPictureMode();

    method public boolean enterPictureInPictureMode(android.app.PictureInPictureArgs);

    method public boolean enterPictureInPictureMode(android.app.PictureInPictureArgs);

    method public android.view.View findViewById(int);

    method public <T extends android.view.View> T findViewById(int);

    method public void finish();

    method public void finish();

    method public void finishActivity(int);

    method public void finishActivity(int);

    method public void finishActivityFromChild(android.app.Activity, int);

    method public void finishActivityFromChild(android.app.Activity, int);
@@ -4509,7 +4509,7 @@ package android.app { 
    method public boolean dispatchPopulateAccessibilityEvent(android.view.accessibility.AccessibilityEvent);

    method public boolean dispatchPopulateAccessibilityEvent(android.view.accessibility.AccessibilityEvent);

    method public boolean dispatchTouchEvent(android.view.MotionEvent);

    method public boolean dispatchTouchEvent(android.view.MotionEvent);

    method public boolean dispatchTrackballEvent(android.view.MotionEvent);

    method public boolean dispatchTrackballEvent(android.view.MotionEvent);

    method public android.view.View findViewById(int);

    method public <T extends android.view.View> T findViewById(int);

    method public android.app.ActionBar getActionBar();

    method public android.app.ActionBar getActionBar();

    method public final android.content.Context getContext();

    method public final android.content.Context getContext();

    method public android.view.View getCurrentFocus();

    method public android.view.View getCurrentFocus();
@@ -50001,7 +50001,7 @@ package android.view { 
    method public void clearFlags(int);

    method public void clearFlags(int);

    method public abstract void closeAllPanels();

    method public abstract void closeAllPanels();

    method public abstract void closePanel(int);

    method public abstract void closePanel(int);

    method public android.view.View findViewById(int);

    method public <T extends android.view.View> T findViewById(int);

    method public boolean getAllowEnterTransitionOverlap();

    method public boolean getAllowEnterTransitionOverlap();

    method public boolean getAllowReturnTransitionOverlap();

    method public boolean getAllowReturnTransitionOverlap();

    method public final android.view.WindowManager.LayoutParams getAttributes();

    method public final android.view.WindowManager.LayoutParams getAttributes();

api/test-current.txt

+3 −3
Original line number Original line Diff line number Diff line
@@ -3580,7 +3580,7 @@ package android.app { 
    method public void dump(java.lang.String, java.io.FileDescriptor, java.io.PrintWriter, java.lang.String[]);

    method public void dump(java.lang.String, java.io.FileDescriptor, java.io.PrintWriter, java.lang.String[]);

    method public void enterPictureInPictureMode();

    method public void enterPictureInPictureMode();

    method public boolean enterPictureInPictureMode(android.app.PictureInPictureArgs);

    method public boolean enterPictureInPictureMode(android.app.PictureInPictureArgs);

    method public android.view.View findViewById(int);

    method public <T extends android.view.View> T findViewById(int);

    method public void finish();

    method public void finish();

    method public void finishActivity(int);

    method public void finishActivity(int);

    method public void finishActivityFromChild(android.app.Activity, int);

    method public void finishActivityFromChild(android.app.Activity, int);
@@ -4370,7 +4370,7 @@ package android.app { 
    method public boolean dispatchPopulateAccessibilityEvent(android.view.accessibility.AccessibilityEvent);

    method public boolean dispatchPopulateAccessibilityEvent(android.view.accessibility.AccessibilityEvent);

    method public boolean dispatchTouchEvent(android.view.MotionEvent);

    method public boolean dispatchTouchEvent(android.view.MotionEvent);

    method public boolean dispatchTrackballEvent(android.view.MotionEvent);

    method public boolean dispatchTrackballEvent(android.view.MotionEvent);

    method public android.view.View findViewById(int);

    method public <T extends android.view.View> T findViewById(int);

    method public android.app.ActionBar getActionBar();

    method public android.app.ActionBar getActionBar();

    method public final android.content.Context getContext();

    method public final android.content.Context getContext();

    method public android.view.View getCurrentFocus();

    method public android.view.View getCurrentFocus();
@@ -46920,7 +46920,7 @@ package android.view { 
    method public void clearFlags(int);

    method public void clearFlags(int);

    method public abstract void closeAllPanels();

    method public abstract void closeAllPanels();

    method public abstract void closePanel(int);

    method public abstract void closePanel(int);

    method public android.view.View findViewById(int);

    method public <T extends android.view.View> T findViewById(int);

    method public boolean getAllowEnterTransitionOverlap();

    method public boolean getAllowEnterTransitionOverlap();

    method public boolean getAllowReturnTransitionOverlap();

    method public boolean getAllowReturnTransitionOverlap();

    method public final android.view.WindowManager.LayoutParams getAttributes();

    method public final android.view.WindowManager.LayoutParams getAttributes();

core/java/android/app/Activity.java

+11 −4
Original line number Original line Diff line number Diff line
@@ -2443,13 +2443,20 @@ public class Activity extends ContextThemeWrapper 
    }

    }





    /**

    /**

     * Finds a view that was identified by the id attribute from the XML that

     * Finds a view that was identified by the {@code android:id} XML attribute

     * was processed in {@link #onCreate}.

     * that was processed in {@link #onCreate}.

     * <p>

     * <strong>Note:</strong> In most cases -- depending on compiler support --

     * the resulting view is automatically cast to the target class type. If

     * the target class type is unconstrained, an explicit cast may be

     * necessary.

     *

     *

     * @return The view if found or null otherwise.

     * @param id the ID to search for

     * @return a view with given ID if found, or {@code null} otherwise

     * @see View#findViewById(int)

     */

     */

    @Nullable

    @Nullable

    public View findViewById(@IdRes int id) {

    public <T extends View> T findViewById(@IdRes int id) {

        return getWindow().findViewById(id);

        return getWindow().findViewById(id);

    }

    }

core/java/android/app/Dialog.java

+14 −6
Original line number Original line Diff line number Diff line
@@ -498,14 +498,22 @@ public class Dialog implements DialogInterface, Window.Callback, 
    }

    }





    /**

    /**

     * Finds a child view with the given identifier. Returns null if the

     * Finds the first descendant view with the given ID or {@code null} if the

     * specified child view does not exist or the dialog has not yet been fully

     * ID is invalid (< 0), there is no matching view in the hierarchy, or the

     * created (for example, via {@link #show()} or {@link #create()}).

     * dialog has not yet been fully created (for example, via {@link #show()}

     * or {@link #create()}).

     * <p>

     * <strong>Note:</strong> In most cases -- depending on compiler support --

     * the resulting view is automatically cast to the target class type. If

     * the target class type is unconstrained, an explicit cast may be

     * necessary.

     *

     *

     * @param id the identifier of the view to find

     * @param id the ID to search for

     * @return The view with the given id or null.

     * @return a view with given ID if found, or {@code null} otherwise

     * @see View#findViewById(int)

     */

     */

    public @Nullable View findViewById(@IdRes int id) {

    @Nullable

    public <T extends View> T findViewById(@IdRes int id) {

        return mWindow.findViewById(id);

        return mWindow.findViewById(id);

    }

    }