Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db17c245 authored by Eghosa Ewansiha-Vlachavas's avatar Eghosa Ewansiha-Vlachavas
Browse files

Fix aspect ratio for transparent letterboxed activity 

Set the `OpenTransparentActivity` to have a min aspect ratio to ensure
the activity is always letterboxed in all orientations.

Flag: NONE(bug fix)
Fixes: 371124711
Fixes: 371125446
Test: atest WMShellFlickerTestsAppCompat:OpenTransparentActivityTest

Change-Id: Id3254a1395e40cd9003d7026da7eb324be01ef4a
parent 2bb66bd6

libs/WindowManager/Shell/tests/flicker/appcompat/src/com/android/wm/shell/flicker/appcompat/OpenTransparentActivityTest.kt

+1 −4
Original line number Diff line number Diff line
@@ -17,7 +17,6 @@ 
package com.android.wm.shell.flicker.appcompat



import android.platform.test.annotations.Postsubmit

import android.tools.Rotation

import android.tools.flicker.assertions.FlickerTest

import android.tools.flicker.junit.FlickerParametersRunnerFactory

import android.tools.flicker.legacy.FlickerBuilder
@@ -109,9 +108,7 @@ class OpenTransparentActivityTest(flicker: LegacyFlickerTest) : TransparentBaseA 
        @Parameterized.Parameters(name = "{0}")

        @JvmStatic

        fun getParams(): Collection<FlickerTest> {

            return LegacyFlickerTestFactory.nonRotationTests(

                supportedRotations = listOf(Rotation.ROTATION_90)

            )

            return LegacyFlickerTestFactory.nonRotationTests()

        }

    }

}

tests/FlickerTests/test-apps/flickerapp/AndroidManifest.xml

+1 −0
Original line number Diff line number Diff line
@@ -156,6 +156,7 @@ 
        <activity android:name=".LaunchTransparentActivity"

                  android:resizeableActivity="false"

                  android:screenOrientation="portrait"

                  android:minAspectRatio="1.77"

                  android:theme="@style/OptOutEdgeToEdge"

                  android:taskAffinity="com.android.server.wm.flicker.testapp.LaunchTransparentActivity"

                  android:label="LaunchTransparentActivity"