Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit daa9d884 authored by Anton Hansson's avatar Anton Hansson
Browse files

Enable compat checking & lint for system_services api 

These were previously turned off as there were no previous
releases to compare it to. Check in empty files as comparison.

Whitelist current lint problems for now (filed bugs to follow-up).

Bug: 149818061
Bug: 149818284
Bug: 147559833
Test: m checkapi
Change-Id: Ib4cbc84ac9a826f7b947c951c94f8f5578f4554d
parent 5562c7e8

services/Android.bp

+10 −0
Original line number Diff line number Diff line
@@ -127,6 +127,16 @@ droidstubs { 
            api_file: "api/current.txt",

            removed_api_file: "api/removed.txt",

        },

        last_released: {

            api_file: ":last-released-system-server-api",

            removed_api_file: "api/removed.txt",

            baseline_file: ":system-server-api-incompatibilities-with-last-released"

        },

        api_lint: {

            enabled: true,

            new_since: ":last-released-system-server-api",

            baseline_file: "api/lint-baseline.txt",

        },

    },

}

services/api/lint-baseline.txt

0 → 100644
+35 −0
Original line number Diff line number Diff line 
// Baseline format: 1.0

InternalClasses: com.android.permission.persistence.RuntimePermissionsPersistence:

    Internal classes must not be exposed

InternalClasses: com.android.permission.persistence.RuntimePermissionsState:

    Internal classes must not be exposed

InternalClasses: com.android.permission.persistence.RuntimePermissionsState.PermissionState:

    Internal classes must not be exposed

InternalClasses: com.android.role.persistence.RolesPersistence:

    Internal classes must not be exposed

InternalClasses: com.android.role.persistence.RolesState:

    Internal classes must not be exposed

InternalClasses: com.android.server.SystemService:

    Internal classes must not be exposed

InternalClasses: com.android.server.SystemService.TargetUser:

    Internal classes must not be exposed





ProtectedMember: com.android.server.SystemService#publishBinderService(String, android.os.IBinder):

    Protected methods not allowed; must be public: method com.android.server.SystemService.publishBinderService(String,android.os.IBinder)}

ProtectedMember: com.android.server.SystemService#publishBinderService(String, android.os.IBinder, boolean):

    Protected methods not allowed; must be public: method com.android.server.SystemService.publishBinderService(String,android.os.IBinder,boolean)}





UserHandleName: com.android.permission.persistence.RuntimePermissionsPersistence#delete(android.os.UserHandle):

    Method taking UserHandle should be named `doFooAsUser` or `queryFooForUser`, was `delete`

UserHandleName: com.android.permission.persistence.RuntimePermissionsPersistence#read(android.os.UserHandle):

    Method taking UserHandle should be named `doFooAsUser` or `queryFooForUser`, was `read`

UserHandleName: com.android.permission.persistence.RuntimePermissionsPersistence#write(com.android.permission.persistence.RuntimePermissionsState, android.os.UserHandle):

    Method taking UserHandle should be named `doFooAsUser` or `queryFooForUser`, was `write`

UserHandleName: com.android.role.persistence.RolesPersistence#delete(android.os.UserHandle):

    Method taking UserHandle should be named `doFooAsUser` or `queryFooForUser`, was `delete`

UserHandleName: com.android.role.persistence.RolesPersistence#read(android.os.UserHandle):

    Method taking UserHandle should be named `doFooAsUser` or `queryFooForUser`, was `read`

UserHandleName: com.android.role.persistence.RolesPersistence#write(com.android.role.persistence.RolesState, android.os.UserHandle):

    Method taking UserHandle should be named `doFooAsUser` or `queryFooForUser`, was `write`