Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit da7c19c6 authored by Stan Iliev's avatar Stan Iliev
Browse files

Fix light center position for layers 

SkiaLayer::inverseTransformInWindow should be the inverse
matrix of Layer transform. This CL fixes a bug, that matrix
value was not inverted.
This matrix is used in one place: to transform light
center coordinates from device to RenderNode/layer
coordinate space.

Bug: 132758858
Test: Ran test app attached to bug. Manually compared coordinates.
Change-Id: Id8e887276a5296091a8264d7a0b1bcc955620a6a
(cherry picked from commit 36b75f79)
parent f9d07635

libs/hwui/pipeline/skia/SkiaPipeline.cpp

+1 −1
Original line number Diff line number Diff line
@@ -176,7 +176,7 @@ bool SkiaPipeline::createOrUpdateLayer(RenderNode* node, const DamageAccumulator 
            // position

            Matrix4 windowTransform;

            damageAccumulator.computeCurrentTransform(&windowTransform);

            node->getSkiaLayer()->inverseTransformInWindow = windowTransform;

            node->getSkiaLayer()->inverseTransformInWindow.loadInverse(windowTransform);

        } else {

            String8 cachesOutput;

            mRenderThread.cacheManager().dumpMemoryUsage(cachesOutput,