Loading core/tests/coretests/src/android/graphics/PathTest.java +3 −1 Original line number Diff line number Diff line Loading @@ -28,7 +28,9 @@ public class PathTest extends TestCase { final Path.FillType defaultFillType = path.getFillType(); final Path.FillType fillType = Path.FillType.INVERSE_EVEN_ODD; assertFalse(fillType.equals(defaultFillType)); // Sanity check for the test itself. // This test is only meaningful if it changes from the default. assertFalse(fillType.equals(defaultFillType)); path.setFillType(fillType); path.reset(); Loading graphics/java/android/graphics/Region.java +2 −2 Original line number Diff line number Diff line Loading @@ -409,10 +409,10 @@ public class Region implements Parcelable { mNativeRegion = ni; } /* add dummy parameter so constructor can be called from jni without /* Add an unused parameter so constructor can be called from jni without triggering 'not cloneable' exception */ @UnsupportedAppUsage private Region(long ni, int dummy) { private Region(long ni, int unused) { this(ni); } Loading libs/hwui/hwui/Bitmap.cpp +2 −5 Original line number Diff line number Diff line Loading @@ -182,11 +182,8 @@ static SkImageInfo validateAlpha(const SkImageInfo& info) { void Bitmap::reconfigure(const SkImageInfo& newInfo, size_t rowBytes) { mInfo = validateAlpha(newInfo); // Dirty hack is dirty // TODO: Figure something out here, Skia's current design makes this // really hard to work with. Skia really, really wants immutable objects, // but with the nested-ref-count hackery going on that's just not // feasible without going insane trying to figure it out // TODO: Skia intends for SkPixelRef to be immutable, but this method // modifies it. Find another way to support reusing the same pixel memory. this->android_only_reset(mInfo.width(), mInfo.height(), rowBytes); } Loading Loading
core/tests/coretests/src/android/graphics/PathTest.java +3 −1 Original line number Diff line number Diff line Loading @@ -28,7 +28,9 @@ public class PathTest extends TestCase { final Path.FillType defaultFillType = path.getFillType(); final Path.FillType fillType = Path.FillType.INVERSE_EVEN_ODD; assertFalse(fillType.equals(defaultFillType)); // Sanity check for the test itself. // This test is only meaningful if it changes from the default. assertFalse(fillType.equals(defaultFillType)); path.setFillType(fillType); path.reset(); Loading
graphics/java/android/graphics/Region.java +2 −2 Original line number Diff line number Diff line Loading @@ -409,10 +409,10 @@ public class Region implements Parcelable { mNativeRegion = ni; } /* add dummy parameter so constructor can be called from jni without /* Add an unused parameter so constructor can be called from jni without triggering 'not cloneable' exception */ @UnsupportedAppUsage private Region(long ni, int dummy) { private Region(long ni, int unused) { this(ni); } Loading
libs/hwui/hwui/Bitmap.cpp +2 −5 Original line number Diff line number Diff line Loading @@ -182,11 +182,8 @@ static SkImageInfo validateAlpha(const SkImageInfo& info) { void Bitmap::reconfigure(const SkImageInfo& newInfo, size_t rowBytes) { mInfo = validateAlpha(newInfo); // Dirty hack is dirty // TODO: Figure something out here, Skia's current design makes this // really hard to work with. Skia really, really wants immutable objects, // but with the nested-ref-count hackery going on that's just not // feasible without going insane trying to figure it out // TODO: Skia intends for SkPixelRef to be immutable, but this method // modifies it. Find another way to support reusing the same pixel memory. this->android_only_reset(mInfo.width(), mInfo.height(), rowBytes); } Loading