Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d9df20c2 authored by Ben Lin's avatar Ben Lin
Browse files

Don't resize PiP on aspect ratio change if nothing changed. 

Aspect ratio changes could be deferred, and thus only the aspect ratio
itself needs to be updated, but the bounds itself is already correct.

Bug: 234615306
Bug: 241096069
Test: Enter PiP and move it around right after animation finishes
Change-Id: Ia1078a6492358e694d4eadf97fa0f242a4033c6f
parent a6e81f57

libs/WindowManager/Shell/src/com/android/wm/shell/pip/phone/PipController.java

+9 −8
Original line number Diff line number Diff line
@@ -495,15 +495,16 @@ public class PipController implements PipTransitionController.PipTransitionCallb 
                                        mPipBoundsState.getBounds(),

                                        mPipBoundsState.getAspectRatio());

                        Objects.requireNonNull(destinationBounds, "Missing destination bounds");

                        if (!destinationBounds.equals(mPipBoundsState.getBounds())) {

                            mPipTaskOrganizer.scheduleAnimateResizePip(destinationBounds,

                                    mEnterAnimationDuration,

                                    null /* updateBoundsCallback */);



                            mTouchHandler.onAspectRatioChanged();

                            updateMovementBounds(null /* toBounds */, false /* fromRotation */,

                                    false /* fromImeAdjustment */, false /* fromShelfAdjustment */,

                                    null /* windowContainerTransaction */);

                        }

                    }



                    @Override

                    public void onActionsChanged(List<RemoteAction> actions,