Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d9230f93 authored by Nate Myren's avatar Nate Myren
Browse files

Revert "Ensure GRANTED_BY_DEFAULT properly cleared in NMS" 

This reverts commit 95336950.

Reason for revert: b/298154056

Test: atest PermissionHelperTest

Change-Id: I13cf9b7c883faf47a09eca73ac3648ece380b6f8
parent 4a983ac1

services/core/java/com/android/server/notification/PermissionHelper.java

+0 −2
Original line number Diff line number Diff line
@@ -16,7 +16,6 @@ 


package com.android.server.notification;



import static android.content.pm.PackageManager.FLAG_PERMISSION_GRANTED_BY_DEFAULT;

import static android.content.pm.PackageManager.FLAG_PERMISSION_USER_FIXED;

import static android.content.pm.PackageManager.FLAG_PERMISSION_USER_SET;

import static android.content.pm.PackageManager.GET_PERMISSIONS;
@@ -203,7 +202,6 @@ public final class PermissionHelper { 
                        Context.DEVICE_ID_DEFAULT, userId, TAG);

            }

            int flagMask = FLAG_PERMISSION_USER_SET | FLAG_PERMISSION_USER_FIXED;

            flagMask = userSet || !grant ? flagMask | FLAG_PERMISSION_GRANTED_BY_DEFAULT : flagMask;

            if (userSet) {

                mPermManager.updatePermissionFlags(packageName, NOTIFICATION_PERMISSION, flagMask,

                        FLAG_PERMISSION_USER_SET, true, Context.DEVICE_ID_DEFAULT, userId);

services/tests/uiservicestests/src/com/android/server/notification/PermissionHelperTest.java

+4 −8
Original line number Diff line number Diff line
@@ -248,8 +248,7 @@ public class PermissionHelperTest extends UiServiceTestCase { 
        verify(mPermManager).grantRuntimePermission(

                "pkg", Manifest.permission.POST_NOTIFICATIONS, Context.DEVICE_ID_DEFAULT, 10);

        verify(mPermManager).updatePermissionFlags("pkg", Manifest.permission.POST_NOTIFICATIONS,

                USER_FLAG_MASK | FLAG_PERMISSION_GRANTED_BY_DEFAULT,

                FLAG_PERMISSION_USER_SET, true, Context.DEVICE_ID_DEFAULT, 10);

                USER_FLAG_MASK, FLAG_PERMISSION_USER_SET, true, Context.DEVICE_ID_DEFAULT, 10);

    }



    @Test
@@ -267,8 +266,7 @@ public class PermissionHelperTest extends UiServiceTestCase { 
        verify(mPermManager).grantRuntimePermission(

                "pkg", Manifest.permission.POST_NOTIFICATIONS, Context.DEVICE_ID_DEFAULT, 10);

        verify(mPermManager).updatePermissionFlags("pkg", Manifest.permission.POST_NOTIFICATIONS,

                USER_FLAG_MASK | FLAG_PERMISSION_GRANTED_BY_DEFAULT,

                FLAG_PERMISSION_USER_SET, true, Context.DEVICE_ID_DEFAULT, 10);

                USER_FLAG_MASK, FLAG_PERMISSION_USER_SET, true, Context.DEVICE_ID_DEFAULT, 10);

    }



    @Test
@@ -282,8 +280,7 @@ public class PermissionHelperTest extends UiServiceTestCase { 
                eq("pkg"), eq(Manifest.permission.POST_NOTIFICATIONS),

                eq(Context.DEVICE_ID_DEFAULT), eq(10), anyString());

        verify(mPermManager).updatePermissionFlags("pkg", Manifest.permission.POST_NOTIFICATIONS,

                USER_FLAG_MASK | FLAG_PERMISSION_GRANTED_BY_DEFAULT,

                FLAG_PERMISSION_USER_SET, true, Context.DEVICE_ID_DEFAULT, 10);

                USER_FLAG_MASK, FLAG_PERMISSION_USER_SET, true, Context.DEVICE_ID_DEFAULT, 10);

    }



    @Test
@@ -310,8 +307,7 @@ public class PermissionHelperTest extends UiServiceTestCase { 
                eq("pkg"), eq(Manifest.permission.POST_NOTIFICATIONS),

                eq(Context.DEVICE_ID_DEFAULT), eq(10), anyString());

        verify(mPermManager).updatePermissionFlags("pkg", Manifest.permission.POST_NOTIFICATIONS,

                USER_FLAG_MASK | FLAG_PERMISSION_GRANTED_BY_DEFAULT, 0,

                true, Context.DEVICE_ID_DEFAULT, 10);

                USER_FLAG_MASK, 0, true, Context.DEVICE_ID_DEFAULT, 10);

    }



    @Test