Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d881cd5a authored Jun 18, 2024 by Brad Hinegardner

Fingerprint sensor should be AccessibilityHintType BOUNCER

Fingerprint sensor and lock icon should both go to bouncer when
activated via a11y actions.

Tested this with Talkback as well as the latest version of Switch
Access to validate that both of the bugs are fixed

Fixes: 344493721
Fixes: 344740341
Test: manual - activate talkback and be able to activate the udfps to go to bouncer
Test: manual - activate switch access and be able to activate all elements on lockscreen
Test: atest DeviceEntryIconViewModelTest
Flag: EXEMPT bugfix
Change-Id: I5a6997ef353d10032ba97a3cccc8bdc5696db167

parent 213782d7

packages/SystemUI/multivalentTests/src/com/android/systemui/keyguard/ui/viewmodel/DeviceEntryIconViewModelTest.kt

+9 −0

Original line number	Original line	Diff line number	Diff line
	@@ -224,6 +224,15 @@ class DeviceEntryIconViewModelTest : SysuiTestCase() {
	// interactive lock icon		// interactive lock icon
	setUpState(isUdfpsSupported = true)		setUpState(isUdfpsSupported = true)

			assertThat(accessibilityDelegateHint)
			.isEqualTo(DeviceEntryIconView.AccessibilityHintType.BOUNCER)

			// udfps running
			setUpState(
			isUdfpsSupported = true,
			isUdfpsRunning = true,
			)

	assertThat(accessibilityDelegateHint)		assertThat(accessibilityDelegateHint)
	.isEqualTo(DeviceEntryIconView.AccessibilityHintType.BOUNCER)		.isEqualTo(DeviceEntryIconView.AccessibilityHintType.BOUNCER)

packages/SystemUI/src/com/android/systemui/keyguard/ui/viewmodel/DeviceEntryIconViewModel.kt

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -284,9 +284,9 @@ constructor(
	private fun DeviceEntryIconView.IconType.toAccessibilityHintType():		private fun DeviceEntryIconView.IconType.toAccessibilityHintType():
	DeviceEntryIconView.AccessibilityHintType {		DeviceEntryIconView.AccessibilityHintType {
	return when (this) {		return when (this) {
			DeviceEntryIconView.IconType.FINGERPRINT,
	DeviceEntryIconView.IconType.LOCK -> DeviceEntryIconView.AccessibilityHintType.BOUNCER		DeviceEntryIconView.IconType.LOCK -> DeviceEntryIconView.AccessibilityHintType.BOUNCER
	DeviceEntryIconView.IconType.UNLOCK -> DeviceEntryIconView.AccessibilityHintType.ENTER		DeviceEntryIconView.IconType.UNLOCK -> DeviceEntryIconView.AccessibilityHintType.ENTER
	DeviceEntryIconView.IconType.FINGERPRINT,
	DeviceEntryIconView.IconType.NONE -> DeviceEntryIconView.AccessibilityHintType.NONE		DeviceEntryIconView.IconType.NONE -> DeviceEntryIconView.AccessibilityHintType.NONE
	}		}
	}		}