Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d853e817 authored by Roman Birg's avatar Roman Birg
Browse files

SystemUI: fix up initial cursor down flags on nav bar 



We were using the regular flags for the initial ACTION_DOWN event so the
FLAG_KEEP_TOUCH_MODE was not being passed and allowed the cursor to jump
out of bounds slightly.

Change-Id: I5b4d2a5e5e0ce562985fcc3b7b6fac8b4abc49da
Signed-off-by: default avatarRoman Birg <roman@cyngn.com>
parent a4ed0776

packages/SystemUI/src/com/android/systemui/statusbar/policy/KeyButtonView.java

+9 −4
Original line number Diff line number Diff line
@@ -52,7 +52,7 @@ public class KeyButtonView extends ImageView { 


    final float GLOW_MAX_SCALE_FACTOR = 1.8f;

    public static final float DEFAULT_QUIESCENT_ALPHA = 0.70f;

    public static final int CURSOR_FLAGS = KeyEvent.FLAG_SOFT_KEYBOARD

    public static final int CURSOR_REPEAT_FLAGS = KeyEvent.FLAG_SOFT_KEYBOARD

            | KeyEvent.FLAG_KEEP_TOUCH_MODE;



    long mDownTime;
@@ -80,8 +80,10 @@ public class KeyButtonView extends ImageView { 
            if (isPressed()) {

                // Log.d("KeyButtonView", "longpressed: " + this);

                if (mCode == KeyEvent.KEYCODE_DPAD_LEFT || mCode == KeyEvent.KEYCODE_DPAD_RIGHT) {

                    sendEvent(KeyEvent.ACTION_UP, CURSOR_FLAGS, System.currentTimeMillis(), false);

                    sendEvent(KeyEvent.ACTION_DOWN, CURSOR_FLAGS, System.currentTimeMillis(), false);

                    sendEvent(KeyEvent.ACTION_UP, CURSOR_REPEAT_FLAGS,

                            System.currentTimeMillis(), false);

                    sendEvent(KeyEvent.ACTION_DOWN, CURSOR_REPEAT_FLAGS,

                            System.currentTimeMillis(), false);

                    postDelayed(mCheckLongPress, ViewConfiguration.getKeyRepeatDelay());

                } else if (mCode != 0) {

                    sendEvent(KeyEvent.ACTION_DOWN, KeyEvent.FLAG_LONG_PRESS);
@@ -320,7 +322,10 @@ public class KeyButtonView extends ImageView { 
                //Log.d("KeyButtonView", "press");

                mDownTime = SystemClock.uptimeMillis();

                setPressed(true);

                if (mCode != 0) {

                if (mCode == KeyEvent.KEYCODE_DPAD_LEFT || mCode == KeyEvent.KEYCODE_DPAD_RIGHT) {

                    sendEvent(KeyEvent.ACTION_DOWN, KeyEvent.FLAG_VIRTUAL_HARD_KEY

                            | KeyEvent.FLAG_KEEP_TOUCH_MODE, mDownTime, false);

                } else if (mCode != 0) {

                    sendEvent(KeyEvent.ACTION_DOWN, 0, mDownTime);

                } else {

                    // Provide the same haptic feedback that the system offers for virtual keys.