Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d83e9b53 authored by Jayant Chowdhary's avatar Jayant Chowdhary
Browse files

Limit preview stabilization mandatory stream sizes to 1440p (instead of RECORD). 



Also fix a logic error in an if check while retrieving mandatory streams
for preview stabilization. This was not caught by CTS since for devices
where preview stabilization was supported, skipped the test. A
modification has been made to CTS RobustnessTest to ensure that the
preview stabilization support and mandatory streams are in agreement
with each other.

Bug: 228245412

Test: atest RobustnessTest.java on device supporting preview stabilization

Change-Id: I18c7f3c728862866b8f088da3afe222afbad7051
Signed-off-by: default avatarJayant Chowdhary <jchowdhary@google.com>
parent cb417881

core/java/android/hardware/camera2/CameraDevice.java

+3 −3
Original line number Original line Diff line number Diff line
@@ -892,9 +892,9 @@ public abstract class CameraDevice implements AutoCloseable { 
     * <tr><th colspan="7">Preview stabilization guaranteed stream configurations</th></tr>

     * <tr><th colspan="7">Preview stabilization guaranteed stream configurations</th></tr>

     * <tr><th colspan="2" id="rb">Target 1</th><th colspan="2" id="rb">Target 2</th><th rowspan="2">Sample use case(s)</th> </tr>

     * <tr><th colspan="2" id="rb">Target 1</th><th colspan="2" id="rb">Target 2</th><th rowspan="2">Sample use case(s)</th> </tr>

     * <tr><th>Type</th><th id="rb">Max size</th><th>Type</th><th id="rb">Max size</th></tr>

     * <tr><th>Type</th><th id="rb">Max size</th><th>Type</th><th id="rb">Max size</th></tr>

     * <tr> <td>{@code PRIV / YUV}</td><td id="rb">{@code RECORD}</td><td colspan="4" id="rb"></td> <td>Stabilized preview, GPU video processing, or no-preview stabilized video recording.</td> </tr>

     * <tr> <td>{@code PRIV / YUV}</td><td id="rb">{@code s1440p}</td><td colspan="4" id="rb"></td> <td>Stabilized preview, GPU video processing, or no-preview stabilized video recording.</td> </tr>

     * <tr> <td>{@code PRIV / YUV}</td><td id="rb">{@code PREVIEW}</td> <td>{@code JPEG / YUV}</td><td id="rb">{@code MAXIMUM }</td><td>Standard still imaging with stabilized preview.</td> </tr>

     * <tr> <td>{@code PRIV / YUV}</td><td id="rb">{@code s1440p}</td> <td>{@code JPEG / YUV}</td><td id="rb">{@code MAXIMUM }</td><td>Standard still imaging with stabilized preview.</td> </tr>

     * <tr> <td>{@code PRIV / YUV}</td><td id="rb">{@code PREVIEW}</td> <td>{@code PRIV / YUV}</td><td id="rb">{@code RECORD }</td><td>High-resolution recording with stabilized preview and recording stream.</td> </tr>

     * <tr> <td>{@code PRIV / YUV}</td><td id="rb">{@code PREVIEW}</td> <td>{@code PRIV / YUV}</td><td id="rb">{@code s1440p }</td><td>High-resolution recording with stabilized preview and recording stream.</td> </tr>

     * </table><br>

     * </table><br>

     * <p>

     * <p>

     * For the maximum size column, PREVIEW refers to the best size match to the device's screen

     * For the maximum size column, PREVIEW refers to the best size match to the device's screen

core/java/android/hardware/camera2/params/MandatoryStreamCombination.java

+11 −11
Original line number Original line Diff line number Diff line
@@ -1265,43 +1265,43 @@ public final class MandatoryStreamCombination { 
    private static StreamCombinationTemplate sPreviewStabilizedStreamCombinations[] = {

    private static StreamCombinationTemplate sPreviewStabilizedStreamCombinations[] = {

        // 1 stream combinations

        // 1 stream combinations

        new StreamCombinationTemplate(new StreamTemplate [] {

        new StreamCombinationTemplate(new StreamTemplate [] {

                new StreamTemplate(ImageFormat.PRIVATE, SizeThreshold.RECORD)},

                new StreamTemplate(ImageFormat.PRIVATE, SizeThreshold.s1440p)},

                "Stabilized preview, GPU video processing, or no-preview stabilized recording"),

                "Stabilized preview, GPU video processing, or no-preview stabilized recording"),

        new StreamCombinationTemplate(new StreamTemplate [] {

        new StreamCombinationTemplate(new StreamTemplate [] {

                new StreamTemplate(ImageFormat.YUV_420_888, SizeThreshold.RECORD)},

                new StreamTemplate(ImageFormat.YUV_420_888, SizeThreshold.s1440p)},

                "Stabilized preview, GPU video processing, or no-preview stabilized recording"),

                "Stabilized preview, GPU video processing, or no-preview stabilized recording"),

        //2 stream combinations

        //2 stream combinations

        new StreamCombinationTemplate(new StreamTemplate [] {

        new StreamCombinationTemplate(new StreamTemplate [] {

                new StreamTemplate(ImageFormat.JPEG, SizeThreshold.MAXIMUM),

                new StreamTemplate(ImageFormat.JPEG, SizeThreshold.MAXIMUM),

                new StreamTemplate(ImageFormat.PRIVATE, SizeThreshold.PREVIEW)},

                new StreamTemplate(ImageFormat.PRIVATE, SizeThreshold.s1440p)},

                "Standard JPEG still imaging with stabilized preview"),

                "Standard JPEG still imaging with stabilized preview"),

        new StreamCombinationTemplate(new StreamTemplate [] {

        new StreamCombinationTemplate(new StreamTemplate [] {

                new StreamTemplate(ImageFormat.YUV_420_888, SizeThreshold.MAXIMUM),

                new StreamTemplate(ImageFormat.YUV_420_888, SizeThreshold.MAXIMUM),

                new StreamTemplate(ImageFormat.PRIVATE, SizeThreshold.PREVIEW)},

                new StreamTemplate(ImageFormat.PRIVATE, SizeThreshold.s1440p)},

                "Standard YUV still imaging with stabilized preview"),

                "Standard YUV still imaging with stabilized preview"),

        new StreamCombinationTemplate(new StreamTemplate [] {

        new StreamCombinationTemplate(new StreamTemplate [] {

                new StreamTemplate(ImageFormat.YUV_420_888, SizeThreshold.MAXIMUM),

                new StreamTemplate(ImageFormat.YUV_420_888, SizeThreshold.MAXIMUM),

                new StreamTemplate(ImageFormat.YUV_420_888, SizeThreshold.PREVIEW)},

                new StreamTemplate(ImageFormat.YUV_420_888, SizeThreshold.s1440p)},

                "Standard YUV still imaging with stabilized in-app image processing stream"),

                "Standard YUV still imaging with stabilized in-app image processing stream"),

        new StreamCombinationTemplate(new StreamTemplate [] {

        new StreamCombinationTemplate(new StreamTemplate [] {

                new StreamTemplate(ImageFormat.JPEG, SizeThreshold.MAXIMUM),

                new StreamTemplate(ImageFormat.JPEG, SizeThreshold.MAXIMUM),

                new StreamTemplate(ImageFormat.YUV_420_888, SizeThreshold.PREVIEW)},

                new StreamTemplate(ImageFormat.YUV_420_888, SizeThreshold.s1440p)},

                "Standard JPEG still imaging with stabilized in-app image processing stream"),

                "Standard JPEG still imaging with stabilized in-app image processing stream"),





        new StreamCombinationTemplate(new StreamTemplate [] {

        new StreamCombinationTemplate(new StreamTemplate [] {

                new StreamTemplate(ImageFormat.PRIVATE, SizeThreshold.RECORD),

                new StreamTemplate(ImageFormat.PRIVATE, SizeThreshold.s1440p),

                new StreamTemplate(ImageFormat.PRIVATE, SizeThreshold.PREVIEW)},

                new StreamTemplate(ImageFormat.PRIVATE, SizeThreshold.PREVIEW)},

                "High-resolution video recording with preview both streams stabilized"),

                "High-resolution video recording with preview both streams stabilized"),

        new StreamCombinationTemplate(new StreamTemplate [] {

        new StreamCombinationTemplate(new StreamTemplate [] {

                new StreamTemplate(ImageFormat.PRIVATE, SizeThreshold.RECORD),

                new StreamTemplate(ImageFormat.PRIVATE, SizeThreshold.s1440p),

                new StreamTemplate(ImageFormat.YUV_420_888, SizeThreshold.PREVIEW)},

                new StreamTemplate(ImageFormat.YUV_420_888, SizeThreshold.PREVIEW)},

                "High-resolution video recording with preview both streams stabilized"),

                "High-resolution video recording with preview both streams stabilized"),

        new StreamCombinationTemplate(new StreamTemplate [] {

        new StreamCombinationTemplate(new StreamTemplate [] {

                new StreamTemplate(ImageFormat.YUV_420_888, SizeThreshold.RECORD),

                new StreamTemplate(ImageFormat.YUV_420_888, SizeThreshold.s1440p),

                new StreamTemplate(ImageFormat.YUV_420_888, SizeThreshold.PREVIEW)},

                new StreamTemplate(ImageFormat.YUV_420_888, SizeThreshold.PREVIEW)},

                "High-resolution video recording with preview both streams stabilized"),

                "High-resolution video recording with preview both streams stabilized"),

        new StreamCombinationTemplate(new StreamTemplate [] {

        new StreamCombinationTemplate(new StreamTemplate [] {

                new StreamTemplate(ImageFormat.YUV_420_888, SizeThreshold.RECORD),

                new StreamTemplate(ImageFormat.YUV_420_888, SizeThreshold.s1440p),

                new StreamTemplate(ImageFormat.PRIVATE, SizeThreshold.PREVIEW)},

                new StreamTemplate(ImageFormat.PRIVATE, SizeThreshold.PREVIEW)},

                "High-resolution video recording with preview both streams stabilized"),

                "High-resolution video recording with preview both streams stabilized"),

    };

    };
@@ -1430,7 +1430,7 @@ public final class MandatoryStreamCombination { 
            StreamCombinationTemplate []chosenStreamCombinations =

            StreamCombinationTemplate []chosenStreamCombinations =

                    sPreviewStabilizedStreamCombinations;

                    sPreviewStabilizedStreamCombinations;





            if (mIsPreviewStabilizationSupported) {

            if (!mIsPreviewStabilizationSupported) {

                Log.v(TAG, "Device does not support preview stabilization");

                Log.v(TAG, "Device does not support preview stabilization");

                 return null;

                 return null;

             }

             }