Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d83a3bc4 authored by Fabian Kozynski's avatar Fabian Kozynski Committed by Automerger Merge Worker
Browse files

Merge "Fix some dimens in dialog" into sc-qpr1-dev am: 38c00180 

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15886624

Change-Id: I77b2be08b3c0e5eb4b1d3c84039c120f0126f2fc
parents a301e7de 38c00180

packages/SystemUI/res/layout/privacy_dialog.xml

+4 −4
Original line number Diff line number Diff line
@@ -24,9 +24,9 @@ 
    android:layout_marginEnd="@dimen/ongoing_appops_dialog_side_margins"

    android:layout_marginTop="8dp"

    android:orientation="vertical"

    android:paddingBottom="12dp"

    android:paddingTop="8dp"

    android:paddingBottom="8dp"

    android:paddingTop="12dp"

    android:paddingHorizontal="@dimen/ongoing_appops_dialog_side_padding"

    android:background="@drawable/qs_dialog_bg"

/>

<!-- 12dp padding bottom so there's 20dp total under the icon -->

<!-- 8dp padding top, as there's 4dp margin in each row -->
 
 No newline at end of file
 
<!-- 8dp padding bottom so there's 16dp total under the icon -->
 
 No newline at end of file

packages/SystemUI/res/layout/privacy_dialog_item.xml

+0 −2
Original line number Diff line number Diff line
@@ -24,8 +24,6 @@ 
    android:layout_marginTop="4dp"

    android:importantForAccessibility="yes"

    android:background="?android:attr/selectableItemBackground"

    android:paddingLeft="@dimen/ongoing_appops_dialog_side_padding"

    android:paddingRight="@dimen/ongoing_appops_dialog_side_padding"

    android:focusable="true"

    >

    <!-- 4dp marginTop makes 20dp minimum between icons -->

packages/SystemUI/res/values/dimens.xml

+1 −1
Original line number Diff line number Diff line
@@ -1279,7 +1279,7 @@ 


    <dimen name="ongoing_appops_dialog_circle_size">32dp</dimen>



    <dimen name="ongoing_appops_dialog_icon_size">20dp</dimen>

    <dimen name="ongoing_appops_dialog_icon_size">16dp</dimen>



    <dimen name="ongoing_appops_dialog_side_padding">16dp</dimen>