Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d7e56f5b authored by Robert Carr's avatar Robert Carr Committed by Rob Carr
Browse files

Update wallpaper offset when changing target from null 

updateWallpaperOffsetLocked copies the IPC received values to the state
variables that are actually set on the wallpaper window. It skips
this job when there is no wallpaper target. In a situation where we are
going from no wallpaper target to wallpaper target (e.g. lock screen
wallpaper) there may be nothing to trigger this method to be called
again when we finally receive a wallpaper target, and we then have
to wait for another IPC. Since there were some values ignored, it
can lead to some jank/misalignment.

Bug: 195596603
Test: Repro from bug.
Change-Id: I3ef19b77bc33546a3e80bca75532d017b4712054
parent 23ee1b87

services/core/java/com/android/server/wm/WallpaperController.java

+3 −0
Original line number Diff line number Diff line
@@ -549,6 +549,9 @@ class WallpaperController { 
        final WindowState prevWallpaperTarget = mWallpaperTarget;

        mWallpaperTarget = wallpaperTarget;



        if (prevWallpaperTarget == null && wallpaperTarget != null) {

            updateWallpaperOffsetLocked(mWallpaperTarget, false);

        }

        if (wallpaperTarget == null || prevWallpaperTarget == null) {

            return;

        }