Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d7e3cf8e authored by Omer Ozer's avatar Omer Ozer
Browse files

Clear/restore calling app identity prior to ui launch. 

Bug: 274160895
Test: local
Change-Id: I78124ced16c9703892d36069c33bedbe29ce22e2
parent 6e07340e

services/credentials/java/com/android/server/credentials/GetRequestSession.java

+6 −4
Original line number Diff line number Diff line
@@ -27,6 +27,7 @@ import android.credentials.GetCredentialResponse; 
import android.credentials.IGetCredentialCallback;

import android.credentials.ui.ProviderData;

import android.credentials.ui.RequestInfo;

import android.os.Binder;

import android.os.CancellationSignal;

import android.os.RemoteException;

import android.service.credentials.CallingAppInfo;
@@ -84,11 +85,12 @@ public class GetRequestSession extends RequestSession<GetCredentialRequest, 
    protected void launchUiWithProviderData(ArrayList<ProviderData> providerDataList) {

        mChosenProviderFinalPhaseMetric.setUiCallStartTimeNanoseconds(System.nanoTime());

        try {

            Binder.withCleanCallingIdentity(() ->

                    mClientCallback.onPendingIntent(mCredentialManagerUi.createPendingIntent(

                    RequestInfo.newGetRequestInfo(

                            mRequestId, mClientRequest, mClientAppInfo.getPackageName()),

                    providerDataList));

        } catch (RemoteException e) {

                    providerDataList)));

        } catch (RuntimeException e) {

            mChosenProviderFinalPhaseMetric.setUiReturned(false);

            respondToClientWithErrorAndFinish(

                    GetCredentialException.TYPE_UNKNOWN, "Unable to instantiate selector");