Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d7b8af13 authored by Stan Iliev's avatar Stan Iliev
Browse files

Fix VectorDrawable dirty flag logic 

Pass VD staging dirty flag value to the render thread dirty flag.
This is fixing animation on growing VD bounds, which looked bad
because cache was not refreshed and scaling it up 100 times did
not look good.

Test: Ran GoogleCamera app and HWUI unit tests.
Bug: 65534766
Change-Id: Ie83cbb6839c772556340b4ec526ba3699fc84255
parent 2eba753d

libs/hwui/VectorDrawable.h

+10 −0
Original line number Diff line number Diff line
@@ -558,6 +558,16 @@ public: 
    SkPaint* getPaint();

    void syncProperties() {

        if (mStagingProperties.mNonAnimatablePropertiesDirty) {

            mCache.dirty |= (mProperties.mNonAnimatableProperties.viewportWidth

                    != mStagingProperties.mNonAnimatableProperties.viewportWidth)

                    || (mProperties.mNonAnimatableProperties.viewportHeight

                    != mStagingProperties.mNonAnimatableProperties.viewportHeight)

                    || (mProperties.mNonAnimatableProperties.scaledWidth

                    != mStagingProperties.mNonAnimatableProperties.scaledWidth)

                    || (mProperties.mNonAnimatableProperties.scaledHeight

                    != mStagingProperties.mNonAnimatableProperties.scaledHeight)

                    || (mProperties.mNonAnimatableProperties.bounds

                    != mStagingProperties.mNonAnimatableProperties.bounds);

            mProperties.syncNonAnimatableProperties(mStagingProperties);

            mStagingProperties.mNonAnimatablePropertiesDirty = false;

        }