Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d736d4b8 authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

Fix/suppress renderthread google-explicit-constructor warnings 

* Add explicit to conversion constructors/operators
* Use NOLINT or NOLINTNEXTLINE to suppress warnings on intended converters

Bug: 28341362
Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,google-explicit-constructor
Change-Id: Ib7d634bf1e0e9a1dda35b0a1d92de4d460193296
parent bcf293c6

libs/hwui/renderthread/CacheManager.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -59,7 +59,7 @@ public: 
private:

private:

    friend class RenderThread;

    friend class RenderThread;





    CacheManager(const DisplayInfo& display);

    explicit CacheManager(const DisplayInfo& display);





    void reset(sk_sp<GrContext> grContext);

    void reset(sk_sp<GrContext> grContext);

    void destroy();

    void destroy();

libs/hwui/renderthread/VulkanManager.h

+1 −0
Original line number Original line Diff line number Diff line
@@ -127,6 +127,7 @@ private: 
            fPtr = ptr;

            fPtr = ptr;

            return *this;

            return *this;

        }

        }

        // NOLINTNEXTLINE(google-explicit-constructor)

        operator FNPTR_TYPE() const { return fPtr; }

        operator FNPTR_TYPE() const { return fPtr; }





    private:

    private: