Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d734d347 authored by Lucas Lin's avatar Lucas Lin Committed by Automerger Merge Worker
Browse files

Merge "Add annotation for Vpn#getNetwork()" am: 8db8d890 

Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1653946

Change-Id: I3be5109c253365b3c5bc56ae48114f8e37c4f153
parents e648a78c 8db8d890

services/core/java/com/android/server/connectivity/Vpn.java

+2 −0
Original line number Diff line number Diff line
@@ -1131,6 +1131,8 @@ public class Vpn { 
     * @return a Network if there is a running VPN network or null if there is no running VPN

     *         network or network is null.

     */

    @VisibleForTesting

    @Nullable

    public synchronized Network getNetwork() {

        final NetworkAgent agent = mNetworkAgent;

        if (null == agent) return null;

tests/net/java/com/android/server/ConnectivityServiceTest.java

+6 −10
Original line number Diff line number Diff line
@@ -37,7 +37,6 @@ import static android.net.ConnectivityManager.BLOCKED_REASON_NONE; 
import static android.net.ConnectivityManager.CONNECTIVITY_ACTION;

import static android.net.ConnectivityManager.EXTRA_NETWORK_INFO;

import static android.net.ConnectivityManager.EXTRA_NETWORK_TYPE;

import static android.net.ConnectivityManager.NETID_UNSET;

import static android.net.ConnectivityManager.PRIVATE_DNS_MODE_OFF;

import static android.net.ConnectivityManager.PRIVATE_DNS_MODE_OPPORTUNISTIC;

import static android.net.ConnectivityManager.PRIVATE_DNS_MODE_PROVIDER_HOSTNAME;
@@ -1202,12 +1201,10 @@ public class ConnectivityServiceTest { 
                    mNetworkCapabilities);

            mMockNetworkAgent.waitForIdle(TIMEOUT_MS);













            final int expectedNetId = mMockVpn.getNetwork() == null ? NETID_UNSET













                    : mMockVpn.getNetwork().getNetId();













            verify(mMockNetd, times(1)).networkAddUidRanges(eq(expectedNetId),













            verify(mMockNetd, times(1)).networkAddUidRanges(eq(mMockVpn.getNetwork().getNetId()),















                    eq(toUidRangeStableParcels(uids)));















            verify(mMockNetd, never())













                    .networkRemoveUidRanges(eq(expectedNetId), any());













                    .networkRemoveUidRanges(eq(mMockVpn.getNetwork().getNetId()), any());















            mAgentRegistered = true;















            updateState(NetworkInfo.DetailedState.CONNECTED, "registerAgent");















            mNetworkCapabilities.set(mMockNetworkAgent.getNetworkCapabilities());










@@ -9799,14 +9796,13 @@ public class ConnectivityServiceTest {













                exemptUidCaptor.capture());















        assertContainsExactly(exemptUidCaptor.getValue(), Process.VPN_UID, exemptUid);



























        final int expectedNetId = mMockVpn.getNetwork() == null ? NETID_UNSET













                : mMockVpn.getNetwork().getNetId();



























        if (add) {













            inOrder.verify(mMockNetd, times(1)).networkAddUidRanges(eq(expectedNetId),













            inOrder.verify(mMockNetd, times(1))













                    .networkAddUidRanges(eq(mMockVpn.getNetwork().getNetId()),















                    eq(toUidRangeStableParcels(vpnRanges)));















        } else {













            inOrder.verify(mMockNetd, times(1)).networkRemoveUidRanges(eq(expectedNetId),













            inOrder.verify(mMockNetd, times(1))













                    .networkRemoveUidRanges(eq(mMockVpn.getNetwork().getNetId()),















                    eq(toUidRangeStableParcels(vpnRanges)));















        }