Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d7115b62 authored by Michael Bestas's avatar Michael Bestas Committed by Bruno Martins
Browse files

SettingsLib: Always show package name in installed app details

Change-Id: I5c57c63a494bed90bf191234206fa0eb7477c83c
parent c46e3609
Loading
Loading
Loading
Loading
+3 −12
Original line number Diff line number Diff line
@@ -36,7 +36,6 @@ import androidx.compose.ui.platform.LocalContext
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.unit.Dp
import com.android.settingslib.development.DevelopmentSettingsEnabler
import com.android.settingslib.spa.framework.compose.rememberDrawablePainter
import com.android.settingslib.spa.framework.theme.SettingsDimension
import com.android.settingslib.spa.framework.theme.isSpaExpressiveEnabled
@@ -119,17 +118,15 @@ class AppInfoProvider(private val packageInfo: PackageInfo) {
    }

    @Composable
    fun FooterAppVersion(showPackageName: Boolean = rememberIsDevelopmentSettingsEnabled()) {
    fun FooterAppVersion() {
        val context = LocalContext.current
        val footer =
            remember(packageInfo, showPackageName) {
            remember(packageInfo) {
                val list = mutableListOf<String>()
                packageInfo.versionNameBidiWrapped?.let {
                    list += context.getString(R.string.version_text, it)
                }
                if (showPackageName) {
                list += packageInfo.packageName
                }
                list.joinToString(separator = System.lineSeparator())
            }
        if (footer.isBlank()) return
@@ -143,12 +140,6 @@ class AppInfoProvider(private val packageInfo: PackageInfo) {
        }
    }

    @Composable
    private fun rememberIsDevelopmentSettingsEnabled(): Boolean {
        val context = LocalContext.current
        return remember { DevelopmentSettingsEnabler.isDevelopmentSettingsEnabled(context) }
    }

    private companion object {
        /** Wrapped the version name, so its directionality still keep same when RTL. */
        val PackageInfo.versionNameBidiWrapped: String?