Merge "Mark Restricted APN connections as restricted." into oc-dev (d6c9efa3) · Commits · e / os / android_frameworks_base

core/java/android/net/NetworkCapabilities.java

+24 −7

Original line number	Diff line number	Diff line
		@@ -19,6 +19,7 @@ package android.net;
		import android.os.Parcel;
		import android.os.Parcelable;

		import com.android.internal.annotations.VisibleForTesting;
		import com.android.internal.util.BitUtils;

		import java.util.Objects;
		@@ -230,7 +231,8 @@ public final class NetworkCapabilities implements Parcelable {
		* Capabilities that suggest that a network is restricted.
		* {@see #maybeMarkCapabilitiesRestricted}.
		*/
		private static final long RESTRICTED_CAPABILITIES =
		@VisibleForTesting
		/* package */ static final long RESTRICTED_CAPABILITIES =
		(1 << NET_CAPABILITY_CBS) \|
		(1 << NET_CAPABILITY_DUN) \|
		(1 << NET_CAPABILITY_EIMS) \|
		@@ -240,6 +242,17 @@ public final class NetworkCapabilities implements Parcelable {
		(1 << NET_CAPABILITY_RCS) \|
		(1 << NET_CAPABILITY_XCAP);

		/**
		* Capabilities that suggest that a network is unrestricted.
		* {@see #maybeMarkCapabilitiesRestricted}.
		*/
		@VisibleForTesting
		/* package */ static final long UNRESTRICTED_CAPABILITIES =
		(1 << NET_CAPABILITY_INTERNET) \|
		(1 << NET_CAPABILITY_MMS) \|
		(1 << NET_CAPABILITY_SUPL) \|
		(1 << NET_CAPABILITY_WIFI_P2P);

		/**
		* Adds the given capability to this {@code NetworkCapability} instance.
		* Multiple capabilities may be applied sequentially. Note that when searching
		@@ -353,12 +366,16 @@ public final class NetworkCapabilities implements Parcelable {
		* @hide
		*/
		public void maybeMarkCapabilitiesRestricted() {
		// If all the capabilities are typically provided by restricted networks, conclude that this
		// network is restricted.
		if ((mNetworkCapabilities & ~(DEFAULT_CAPABILITIES \| RESTRICTED_CAPABILITIES)) == 0 &&
		// Must have at least some restricted capabilities, otherwise a request for an
		// internet-less network will get marked restricted.
		(mNetworkCapabilities & RESTRICTED_CAPABILITIES) != 0) {
		// Verify there aren't any unrestricted capabilities. If there are we say
		// the whole thing is unrestricted.
		final boolean hasUnrestrictedCapabilities =
		((mNetworkCapabilities & UNRESTRICTED_CAPABILITIES) != 0);

		// Must have at least some restricted capabilities.
		final boolean hasRestrictedCapabilities =
		((mNetworkCapabilities & RESTRICTED_CAPABILITIES) != 0);

		if (hasRestrictedCapabilities && !hasUnrestrictedCapabilities) {
		removeCapability(NET_CAPABILITY_NOT_RESTRICTED);
		}
		}

tests/net/java/android/net/NetworkCapabilitiesTest.java

0 → 100644

+117 −0

Original line number	Diff line number	Diff line
		/*
		* Copyright (C) 2017 The Android Open Source Project
		*
		* Licensed under the Apache License, Version 2.0 (the "License");
		* you may not use this file except in compliance with the License.
		* You may obtain a copy of the License at
		*
		* http://www.apache.org/licenses/LICENSE-2.0
		*
		* Unless required by applicable law or agreed to in writing, software
		* distributed under the License is distributed on an "AS IS" BASIS,
		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
		* See the License for the specific language governing permissions and
		* limitations under the License.
		*/

		package android.net;

		import static android.net.NetworkCapabilities.NET_CAPABILITY_CBS;
		import static android.net.NetworkCapabilities.NET_CAPABILITY_EIMS;
		import static android.net.NetworkCapabilities.NET_CAPABILITY_INTERNET;
		import static android.net.NetworkCapabilities.NET_CAPABILITY_NOT_METERED;
		import static android.net.NetworkCapabilities.NET_CAPABILITY_NOT_RESTRICTED;
		import static android.net.NetworkCapabilities.RESTRICTED_CAPABILITIES;
		import static android.net.NetworkCapabilities.UNRESTRICTED_CAPABILITIES;
		import static org.junit.Assert.assertEquals;
		import static org.junit.Assert.assertFalse;
		import static org.junit.Assert.assertTrue;


		import android.net.NetworkCapabilities;
		import android.support.test.runner.AndroidJUnit4;
		import android.test.suitebuilder.annotation.SmallTest;

		import org.junit.Test;
		import org.junit.runner.RunWith;


		@RunWith(AndroidJUnit4.class)
		@SmallTest
		public class NetworkCapabilitiesTest {
		@Test
		public void testMaybeMarkCapabilitiesRestricted() {
		// verify EIMS is restricted
		assertEquals((1 << NET_CAPABILITY_EIMS) & RESTRICTED_CAPABILITIES,
		(1 << NET_CAPABILITY_EIMS));

		// verify CBS is also restricted
		assertEquals((1 << NET_CAPABILITY_CBS) & RESTRICTED_CAPABILITIES,
		(1 << NET_CAPABILITY_CBS));

		// verify default is not restricted
		assertEquals((1 << NET_CAPABILITY_INTERNET) & RESTRICTED_CAPABILITIES, 0);

		// just to see
		assertEquals(RESTRICTED_CAPABILITIES & UNRESTRICTED_CAPABILITIES, 0);

		// check that internet does not get restricted
		NetworkCapabilities netCap = new NetworkCapabilities();
		netCap.addCapability(NET_CAPABILITY_INTERNET);
		netCap.maybeMarkCapabilitiesRestricted();
		assertTrue(netCap.hasCapability(NET_CAPABILITY_NOT_RESTRICTED));

		// metered-ness shouldn't matter
		netCap = new NetworkCapabilities();
		netCap.addCapability(NET_CAPABILITY_INTERNET);
		netCap.addCapability(NET_CAPABILITY_NOT_METERED);
		netCap.maybeMarkCapabilitiesRestricted();
		assertTrue(netCap.hasCapability(NET_CAPABILITY_NOT_RESTRICTED));
		netCap = new NetworkCapabilities();
		netCap.addCapability(NET_CAPABILITY_INTERNET);
		netCap.removeCapability(NET_CAPABILITY_NOT_METERED);
		netCap.maybeMarkCapabilitiesRestricted();
		assertTrue(netCap.hasCapability(NET_CAPABILITY_NOT_RESTRICTED));

		// add EIMS - bundled with unrestricted means it's unrestricted
		netCap = new NetworkCapabilities();
		netCap.addCapability(NET_CAPABILITY_INTERNET);
		netCap.addCapability(NET_CAPABILITY_EIMS);
		netCap.addCapability(NET_CAPABILITY_NOT_METERED);
		netCap.maybeMarkCapabilitiesRestricted();
		assertTrue(netCap.hasCapability(NET_CAPABILITY_NOT_RESTRICTED));
		netCap = new NetworkCapabilities();
		netCap.addCapability(NET_CAPABILITY_INTERNET);
		netCap.addCapability(NET_CAPABILITY_EIMS);
		netCap.removeCapability(NET_CAPABILITY_NOT_METERED);
		netCap.maybeMarkCapabilitiesRestricted();
		assertTrue(netCap.hasCapability(NET_CAPABILITY_NOT_RESTRICTED));

		// just a restricted cap should be restricted regardless of meteredness
		netCap = new NetworkCapabilities();
		netCap.addCapability(NET_CAPABILITY_EIMS);
		netCap.addCapability(NET_CAPABILITY_NOT_METERED);
		netCap.maybeMarkCapabilitiesRestricted();
		assertFalse(netCap.hasCapability(NET_CAPABILITY_NOT_RESTRICTED));
		netCap = new NetworkCapabilities();
		netCap.addCapability(NET_CAPABILITY_EIMS);
		netCap.removeCapability(NET_CAPABILITY_NOT_METERED);
		netCap.maybeMarkCapabilitiesRestricted();
		assertFalse(netCap.hasCapability(NET_CAPABILITY_NOT_RESTRICTED));

		// try 2 restricted caps
		netCap = new NetworkCapabilities();
		netCap.addCapability(NET_CAPABILITY_CBS);
		netCap.addCapability(NET_CAPABILITY_EIMS);
		netCap.addCapability(NET_CAPABILITY_NOT_METERED);
		netCap.maybeMarkCapabilitiesRestricted();
		assertFalse(netCap.hasCapability(NET_CAPABILITY_NOT_RESTRICTED));
		netCap = new NetworkCapabilities();
		netCap.addCapability(NET_CAPABILITY_CBS);
		netCap.addCapability(NET_CAPABILITY_EIMS);
		netCap.removeCapability(NET_CAPABILITY_NOT_METERED);
		netCap.maybeMarkCapabilitiesRestricted();
		assertFalse(netCap.hasCapability(NET_CAPABILITY_NOT_RESTRICTED));
		}

		}