Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6764fd9 authored by Nataniel Borges's avatar Nataniel Borges
Browse files

Re-enable EnterPipToOtherOrientationTest on tablet 

The original issue found during triage has already been addressed

Fixes: 235375583
Test: atest WMShellFlickerTests
Change-Id: If7ce04cfb8e33c24f1b9a564f6c895e93ad6256d
parent 879d2eae

libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/pip/EnterPipToOtherOrientationTest.kt

+17 −0
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@ 
package com.android.wm.shell.flicker.pip



import android.app.Activity

import android.platform.test.annotations.Postsubmit

import android.platform.test.annotations.Presubmit

import androidx.test.filters.RequiresDevice

import com.android.server.wm.flicker.FlickerBuilder
@@ -28,6 +29,7 @@ import com.android.server.wm.flicker.helpers.WindowUtils 
import com.android.server.wm.flicker.junit.FlickerParametersRunnerFactory

import com.android.server.wm.flicker.testapp.ActivityOptions.Pip.ACTION_ENTER_PIP

import com.android.server.wm.flicker.testapp.ActivityOptions.PortraitOnlyActivity.EXTRA_FIXED_ORIENTATION

import com.android.server.wm.traces.common.ComponentNameMatcher

import com.android.server.wm.traces.common.service.PlatformConsts

import com.android.wm.shell.flicker.pip.PipTransition.BroadcastActionTrigger.Companion.ORIENTATION_LANDSCAPE

import com.android.wm.shell.flicker.pip.PipTransition.BroadcastActionTrigger.Companion.ORIENTATION_PORTRAIT
@@ -163,9 +165,24 @@ open class EnterPipToOtherOrientationTest(flicker: FlickerTest) : PipTransition( 
    @Presubmit

    @Test

    fun pipAppLayerCoversFullScreenOnStart() {

        Assume.assumeFalse(tapl.isTablet)

        flicker.assertLayersStart { visibleRegion(pipApp).coversExactly(startingBounds) }

    }



    /**

     * Checks that the visible region of [pipApp] covers the full display area at the start of the

     * transition

     */

    @Postsubmit

    @Test

    fun pipAppLayerPlusLetterboxCoversFullScreenOnStartTablet() {

        Assume.assumeFalse(tapl.isTablet)

        flicker.assertLayersStart {

            visibleRegion(pipApp.or(ComponentNameMatcher.LETTERBOX))

                .coversExactly(startingBounds)

        }

    }



    /**

     * Checks that the visible region of [testApp] plus the visible region of [pipApp] cover the

     * full display area at the end of the transition