Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6611779 authored by Taran Singh's avatar Taran Singh
Browse files

Don't cache IME surface in fullscreen mode 

Dont cache IME surface when IME was in fullscreen mode. This is done in
order to fix IME closing when it is used with RecyclerView. There can be
a special case where RecyclerView detaches the view holding mServedView
when IME is in fullscreen mode

While exact reason is still a mystery, short term solution is to not
cache IME when it was in fullscreen mode.

Fix: 187772544
Bug: 188818557
Bug: 167948123

Test: Manually using steps in bug
Change-Id: I1194d08a00622f1dfa232209a70dcb0797ba192b
parent 13bd292d

core/java/android/inputmethodservice/InputMethodService.java

+13 −2
Original line number Diff line number Diff line
@@ -481,6 +481,7 @@ public class InputMethodService extends AbstractInputMethodService { 


    boolean mFullscreenApplied;

    boolean mIsFullscreen;

    private boolean mLastWasInFullscreenMode;

    @UnsupportedAppUsage

    View mExtractView;

    boolean mExtractViewHidden;
@@ -920,9 +921,18 @@ public class InputMethodService extends AbstractInputMethodService { 
        if (mHandler == null) {

            mHandler = new Handler(getMainLooper());

        }



        if (mLastWasInFullscreenMode) {

            // Caching surface / delaying surface removal can cause mServedView to detach in certain

            // cases in RecyclerView (b/187772544).

            // TODO(b/188818557): Re-enable IME surface caching for fullscreen mode once detaching

            //  view issues is resolved in RecyclerView.

            removeImeSurface();

        } else {

            mImeSurfaceScheduledForRemoval = true;

            mHandler.postDelayed(() -> removeImeSurface(), TIMEOUT_SURFACE_REMOVAL_MILLIS);

        }

    }



    private void removeImeSurface() {

        // hiding a window removes its surface.
@@ -2350,6 +2360,7 @@ public class InputMethodService extends AbstractInputMethodService { 
            onWindowHidden();

            mDecorViewWasVisible = false;

        }

        mLastWasInFullscreenMode = mIsFullscreen;

        updateFullscreenMode();

    }