Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d64abfcf authored by Narayan Kamath's avatar Narayan Kamath
Browse files

Binder: Be forceful about a forceful exit. 

We were previously using exit(1) when code servicing an IPC threw
any subclass of Error. That made it much harder to diagnose cases
where that happened because :

- exit runs global destructors, which might prove problematic (see
  linked bug).
- such exits are often due to bugs in application code (things like
  AssertionErrors being thrown) but aren't flagged as such by our
  infrastructure, or by humans for that matter.

To address both issues, use FatalError() so that the runtime can dump
more useful information to the logs before it aborts.

Test: manual
Bug: 36813403
Change-Id: I5826090229109dc7cb19f0c3571c609f990cd36a
parent 0ac8fd7a

core/jni/android_util_Binder.cpp

+4 −10
Original line number Diff line number Diff line
@@ -192,18 +192,12 @@ static void report_exception(JNIEnv* env, jthrowable excep, const char* msg) 


    if (env->IsInstanceOf(excep, gErrorOffsets.mClass)) {

        /*

         * It's an Error: Reraise the exception, detach this thread, and

         * wait for the fireworks. Die even more blatantly after a minute

         * if the gentler attempt doesn't do the trick.

         *

         * The GetJavaVM function isn't on the "approved" list of JNI calls

         * that can be made while an exception is pending, so we want to

         * get the VM ptr, throw the exception, and then detach the thread.

         * It's an Error: Reraise the exception and ask the runtime to abort.

         * This will dump the pending exception as well as all thread traces

         * to the log.

         */

        env->Throw(excep);

        env->ExceptionDescribe();

        ALOGE("Forcefully exiting");

        exit(1);

        env->FatalError("java.lang.Error thrown during binder transaction.");

    }



bail: