Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d63fd2f8 authored by Charles Chen's avatar Charles Chen
Browse files

Update Window Extensions library APIs 

Bug: 257937650
Bug: 259218261
fixes: 264025195
Test: manual - using sample app
Test: manual - update prebuilt library and verify in Settings app

Change-Id: Ife8dc02d6f62676c8f06558700afd8b2f75f01c6
parent 44b20d34

libs/WindowManager/Jetpack/Android.bp

+10 −1
Original line number Diff line number Diff line
@@ -63,6 +63,12 @@ android_library_import { 
    sdk_version: "current",

}



android_library_import {

    name: "window-extensions-core",

    aars: ["window-extensions-core-release.aar"],

    sdk_version: "current",

}



java_library {

    name: "androidx.window.extensions",

    srcs: [
@@ -70,7 +76,10 @@ java_library { 
        "src/androidx/window/util/**/*.java",

        "src/androidx/window/common/**/*.java",

    ],

    static_libs: ["window-extensions"],

    static_libs: [

        "window-extensions",

        "window-extensions-core",

    ],

    installable: true,

    sdk_version: "core_platform",

    system_ext_specific: true,

libs/WindowManager/Jetpack/src/androidx/window/extensions/embedding/SplitController.java

+25 −7
Original line number Diff line number Diff line
@@ -77,6 +77,9 @@ import androidx.annotation.Nullable; 
import androidx.window.common.CommonFoldingFeature;

import androidx.window.common.DeviceStateManagerFoldingFeatureProducer;

import androidx.window.common.EmptyLifecycleCallbacksAdapter;

import androidx.window.extensions.WindowExtensionsImpl;

import androidx.window.extensions.core.util.function.Consumer;

import androidx.window.extensions.core.util.function.Function;

import androidx.window.extensions.embedding.TransactionManager.TransactionRecord;

import androidx.window.extensions.layout.WindowLayoutComponentImpl;
@@ -87,7 +90,6 @@ import java.util.List; 
import java.util.Objects;

import java.util.Set;

import java.util.concurrent.Executor;

import java.util.function.Consumer;



/**

 * Main controller class that manages split states and presentation.
@@ -113,7 +115,7 @@ public class SplitController implements JetpackTaskFragmentOrganizer.TaskFragmen 
    /**

     * A developer-defined {@link SplitAttributes} calculator to compute the current

     * {@link SplitAttributes} with the current device and window states.

     * It is registered via {@link #setSplitAttributesCalculator(SplitAttributesCalculator)}

     * It is registered via {@link #setSplitAttributesCalculator(Function)}

     * and unregistered via {@link #clearSplitAttributesCalculator()}.

     * This is called when:

     * <ul>
@@ -126,7 +128,7 @@ public class SplitController implements JetpackTaskFragmentOrganizer.TaskFragmen 
     */

    @GuardedBy("mLock")

    @Nullable

    private SplitAttributesCalculator mSplitAttributesCalculator;

    private Function<SplitAttributesCalculatorParams, SplitAttributes> mSplitAttributesCalculator;



    /**

     * Map from Task id to {@link TaskContainer} which contains all TaskFragment and split pair info
@@ -139,6 +141,7 @@ public class SplitController implements JetpackTaskFragmentOrganizer.TaskFragmen 
    final SparseArray<TaskContainer> mTaskContainers = new SparseArray<>();



    /** Callback to Jetpack to notify about changes to split states. */

    @GuardedBy("mLock")

    @Nullable

    private Consumer<List<SplitInfo>> mEmbeddingCallback;

    private final List<SplitInfo> mLastReportedSplitStates = new ArrayList<>();
@@ -164,7 +167,8 @@ public class SplitController implements JetpackTaskFragmentOrganizer.TaskFragmen 
        foldingFeatureProducer.addDataChangedCallback(new FoldingFeatureListener());

    }



    private class FoldingFeatureListener implements Consumer<List<CommonFoldingFeature>> {

    private class FoldingFeatureListener

            implements java.util.function.Consumer<List<CommonFoldingFeature>> {

        @Override

        public void accept(List<CommonFoldingFeature> foldingFeatures) {

            synchronized (mLock) {
@@ -205,7 +209,8 @@ public class SplitController implements JetpackTaskFragmentOrganizer.TaskFragmen 
    }



    @Override

    public void setSplitAttributesCalculator(@NonNull SplitAttributesCalculator calculator) {

    public void setSplitAttributesCalculator(

            @NonNull Function<SplitAttributesCalculatorParams, SplitAttributes> calculator) {

        synchronized (mLock) {

            mSplitAttributesCalculator = calculator;

        }
@@ -220,7 +225,7 @@ public class SplitController implements JetpackTaskFragmentOrganizer.TaskFragmen 


    @GuardedBy("mLock")

    @Nullable

    SplitAttributesCalculator getSplitAttributesCalculator() {

    Function<SplitAttributesCalculatorParams, SplitAttributes> getSplitAttributesCalculator() {

        return mSplitAttributesCalculator;

    }
@@ -233,9 +238,22 @@ public class SplitController implements JetpackTaskFragmentOrganizer.TaskFragmen 


    /**

     * Registers the split organizer callback to notify about changes to active splits.

     * @deprecated Use {@link #setSplitInfoCallback(Consumer)} starting with

     * {@link WindowExtensionsImpl#getVendorApiLevel()} 2.

     */

    @Deprecated

    @Override

    public void setSplitInfoCallback(@NonNull Consumer<List<SplitInfo>> callback) {

    public void setSplitInfoCallback(

            @NonNull java.util.function.Consumer<List<SplitInfo>> callback) {

        Consumer<List<SplitInfo>> oemConsumer = callback::accept;

        setSplitInfoCallback(oemConsumer);

    }



    /**

     * Registers the split organizer callback to notify about changes to active splits.

     * @since {@link WindowExtensionsImpl#getVendorApiLevel()} 2

     */

    public void setSplitInfoCallback(Consumer<List<SplitInfo>> callback) {

        synchronized (mLock) {

            mEmbeddingCallback = callback;

            updateCallbackIfNecessary();

libs/WindowManager/Jetpack/src/androidx/window/extensions/embedding/SplitPresenter.java

+4 −3
Original line number Diff line number Diff line
@@ -43,11 +43,11 @@ import android.window.WindowContainerTransaction; 
import androidx.annotation.IntDef;

import androidx.annotation.NonNull;

import androidx.annotation.Nullable;

import androidx.window.extensions.core.util.function.Function;

import androidx.window.extensions.embedding.SplitAttributes.SplitType;

import androidx.window.extensions.embedding.SplitAttributes.SplitType.ExpandContainersSplitType;

import androidx.window.extensions.embedding.SplitAttributes.SplitType.HingeSplitType;

import androidx.window.extensions.embedding.SplitAttributes.SplitType.RatioSplitType;

import androidx.window.extensions.embedding.SplitAttributesCalculator.SplitAttributesCalculatorParams;

import androidx.window.extensions.embedding.TaskContainer.TaskProperties;

import androidx.window.extensions.layout.DisplayFeature;

import androidx.window.extensions.layout.FoldingFeature;
@@ -551,7 +551,8 @@ class SplitPresenter extends JetpackTaskFragmentOrganizer { 
            @NonNull SplitRule rule, @Nullable Pair<Size, Size> minDimensionsPair) {

        final Configuration taskConfiguration = taskProperties.getConfiguration();

        final WindowMetrics taskWindowMetrics = getTaskWindowMetrics(taskConfiguration);

        final SplitAttributesCalculator calculator = mController.getSplitAttributesCalculator();

        final Function<SplitAttributesCalculatorParams, SplitAttributes> calculator =

                mController.getSplitAttributesCalculator();

        final SplitAttributes defaultSplitAttributes = rule.getDefaultSplitAttributes();

        final boolean isDefaultMinSizeSatisfied = rule.checkParentMetrics(taskWindowMetrics);

        if (calculator == null) {
@@ -567,7 +568,7 @@ class SplitPresenter extends JetpackTaskFragmentOrganizer { 
        final SplitAttributesCalculatorParams params = new SplitAttributesCalculatorParams(

                taskWindowMetrics, taskConfiguration, defaultSplitAttributes,

                isDefaultMinSizeSatisfied, windowLayoutInfo, rule.getTag());

        final SplitAttributes splitAttributes = calculator.computeSplitAttributesForParams(params);

        final SplitAttributes splitAttributes = calculator.apply(params);

        return sanitizeSplitAttributes(taskProperties, splitAttributes, minDimensionsPair);

    }

libs/WindowManager/Jetpack/src/androidx/window/extensions/layout/WindowLayoutComponentImpl.java

+37 −6
Original line number Diff line number Diff line
@@ -45,6 +45,7 @@ import androidx.annotation.UiContext; 
import androidx.window.common.CommonFoldingFeature;

import androidx.window.common.DeviceStateManagerFoldingFeatureProducer;

import androidx.window.common.EmptyLifecycleCallbacksAdapter;

import androidx.window.extensions.core.util.function.Consumer;

import androidx.window.util.DataProducer;



import java.util.ArrayList;
@@ -53,7 +54,6 @@ import java.util.List; 
import java.util.Map;

import java.util.Objects;

import java.util.Set;

import java.util.function.Consumer;



/**

 * Reference implementation of androidx.window.extensions.layout OEM interface for use with
@@ -82,6 +82,10 @@ public class WindowLayoutComponentImpl implements WindowLayoutComponent { 
    private final Map<IBinder, ConfigurationChangeListener> mConfigurationChangeListeners =

            new ArrayMap<>();



    @GuardedBy("mLock")

    private final Map<java.util.function.Consumer<WindowLayoutInfo>, Consumer<WindowLayoutInfo>>

            mJavaToExtConsumers = new ArrayMap<>();



    private final TaskFragmentOrganizer mTaskFragmentOrganizer;



    public WindowLayoutComponentImpl(@NonNull Context context,
@@ -95,7 +99,8 @@ public class WindowLayoutComponentImpl implements WindowLayoutComponent { 
    }



    /** Registers to listen to {@link CommonFoldingFeature} changes */

    public void addFoldingStateChangedCallback(Consumer<List<CommonFoldingFeature>> consumer) {

    public void addFoldingStateChangedCallback(

            java.util.function.Consumer<List<CommonFoldingFeature>> consumer) {

        synchronized (mLock) {

            mFoldingFeatureProducer.addDataChangedCallback(consumer);

        }
@@ -109,13 +114,27 @@ public class WindowLayoutComponentImpl implements WindowLayoutComponent { 
     */

    @Override

    public void addWindowLayoutInfoListener(@NonNull Activity activity,

            @NonNull Consumer<WindowLayoutInfo> consumer) {

        addWindowLayoutInfoListener((Context) activity, consumer);

            @NonNull java.util.function.Consumer<WindowLayoutInfo> consumer) {

        final Consumer<WindowLayoutInfo> extConsumer = consumer::accept;

        synchronized (mLock) {

            mJavaToExtConsumers.put(consumer, extConsumer);

        }

        addWindowLayoutInfoListener(activity, extConsumer);

    }



    @Override

    public void addWindowLayoutInfoListener(@NonNull @UiContext Context context,

            @NonNull java.util.function.Consumer<WindowLayoutInfo> consumer) {

        final Consumer<WindowLayoutInfo> extConsumer = consumer::accept;

        synchronized (mLock) {

            mJavaToExtConsumers.put(consumer, extConsumer);

        }

        addWindowLayoutInfoListener(context, extConsumer);

    }



    /**

     * Similar to {@link #addWindowLayoutInfoListener(Activity, Consumer)}, but takes a UI Context

     * as a parameter.

     * Similar to {@link #addWindowLayoutInfoListener(Activity, java.util.function.Consumer)}, but

     * takes a UI Context as a parameter.

     *

     * Jetpack {@link androidx.window.layout.ExtensionWindowLayoutInfoBackend} makes sure all

     * consumers related to the same {@link Context} gets updated {@link WindowLayoutInfo}
@@ -156,6 +175,18 @@ public class WindowLayoutComponentImpl implements WindowLayoutComponent { 
        }

    }



    @Override

    public void removeWindowLayoutInfoListener(

            @NonNull java.util.function.Consumer<WindowLayoutInfo> consumer) {

        final Consumer<WindowLayoutInfo> extConsumer;

        synchronized (mLock) {

            extConsumer = mJavaToExtConsumers.remove(consumer);

        }

        if (extConsumer != null) {

            removeWindowLayoutInfoListener(extConsumer);

        }

    }



    /**

     * Removes a listener no longer interested in receiving updates.

     *

libs/WindowManager/Jetpack/tests/unittest/src/androidx/window/extensions/embedding/EmbeddingTestUtils.java

+26 −2
Original line number Diff line number Diff line
@@ -34,9 +34,11 @@ import android.content.res.Resources; 
import android.graphics.Point;

import android.graphics.Rect;

import android.util.Pair;

import android.view.WindowMetrics;

import android.window.TaskFragmentInfo;

import android.window.WindowContainerToken;



import androidx.window.extensions.core.util.function.Predicate;

import androidx.window.extensions.embedding.SplitAttributes.SplitType;

import androidx.window.extensions.layout.DisplayFeature;

import androidx.window.extensions.layout.FoldingFeature;
@@ -107,7 +109,7 @@ public class EmbeddingTestUtils { 
    static SplitRule createSplitRule(@NonNull Activity primaryActivity,

            @NonNull Intent secondaryIntent, boolean clearTop) {

        final Pair<Activity, Intent> targetPair = new Pair<>(primaryActivity, secondaryIntent);

        return new SplitPairRule.Builder(

        return createSplitPairRuleBuilder(

                activityPair -> false,

                targetPair::equals,

                w -> true)
@@ -144,7 +146,7 @@ public class EmbeddingTestUtils { 
            @NonNull Activity secondaryActivity, int finishPrimaryWithSecondary,

            int finishSecondaryWithPrimary, boolean clearTop) {

        final Pair<Activity, Activity> targetPair = new Pair<>(primaryActivity, secondaryActivity);

        return new SplitPairRule.Builder(

        return createSplitPairRuleBuilder(

                targetPair::equals,

                activityIntentPair -> false,

                w -> true)
@@ -223,4 +225,26 @@ public class EmbeddingTestUtils { 
        displayFeatures.add(foldingFeature);

        return new WindowLayoutInfo(displayFeatures);

    }



    static ActivityRule.Builder createActivityBuilder(

            @NonNull Predicate<Activity> activityPredicate,

            @NonNull Predicate<Intent> intentPredicate) {

        return new ActivityRule.Builder(activityPredicate, intentPredicate);

    }



    static SplitPairRule.Builder createSplitPairRuleBuilder(

            @NonNull Predicate<Pair<Activity, Activity>> activitiesPairPredicate,

            @NonNull Predicate<Pair<Activity, Intent>> activityIntentPairPredicate,

            @NonNull Predicate<WindowMetrics> windowMetricsPredicate) {

        return new SplitPairRule.Builder(activitiesPairPredicate, activityIntentPairPredicate,

                windowMetricsPredicate);

    }



    static SplitPlaceholderRule.Builder createSplitPlaceholderRuleBuilder(

            @NonNull Intent placeholderIntent, @NonNull Predicate<Activity> activityPredicate,

            @NonNull Predicate<Intent> intentPredicate,

            @NonNull Predicate<WindowMetrics> windowMetricsPredicate) {

        return new SplitPlaceholderRule.Builder(placeholderIntent, activityPredicate,

                intentPredicate, windowMetricsPredicate);

    }

}