Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d61f73b7 authored by Tetsutoki Shiozawa's avatar Tetsutoki Shiozawa Committed by Ed Savage-Jones
Browse files

Missed call LED pulse notification is... missing 

When a call is received, the screen lights up and the InCallUI is
shown.  If the call goes unanswered a 'missed call' notification
is left, where the LED should also pulse; this pulsing is to indicate
that a missed call occurred even after the screen turns off.

This re-adds that functionality that was removed in:
54369237 Be more strict about triggering notification lights

Bug: 170735830
Test: atest BuzzBeepBlinkTest
Change-Id: If01e8f595affc874b2c9fee82a48283b6aeaceda
parent a5690195

services/core/java/com/android/server/notification/NotificationManagerService.java

+3 −3
Original line number Diff line number Diff line
@@ -6964,15 +6964,15 @@ public class NotificationManagerService extends SystemService { 
        if (record.getSbn().isGroup() && record.getNotification().suppressAlertingDueToGrouping()) {

            return false;

        }

        // not if in call or the screen's on

        if (isInCall() || mScreenOn) {

        // not if in call

        if (isInCall()) {

            return false;

        }

        // check current user

        if (!isNotificationForCurrentUser(record)) {

            return false;

        }



        // Light, but only when the screen is off

        return true;

    }

services/tests/uiservicestests/src/com/android/server/notification/BuzzBeepBlinkTest.java

+1 −1
Original line number Diff line number Diff line
@@ -1185,7 +1185,7 @@ public class BuzzBeepBlinkTest extends UiServiceTestCase { 
        NotificationRecord r = getLightsNotification();

        mService.buzzBeepBlinkLocked(r);

        verifyNeverLights();

        assertFalse(r.isInterruptive());

        assertTrue(r.isInterruptive());

        assertEquals(-1, r.getLastAudiblyAlertedMs());

    }