Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d5ef2d61 authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "API Lint: remove obsolete python linter"

parents d3d5d5a9 7bf3cd9d

PREUPLOAD.cfg

+0 −2
Original line number Diff line number Diff line 
[Hook Scripts]

checkstyle_hook = ${REPO_ROOT}/prebuilts/checkstyle/checkstyle.py --sha ${PREUPLOAD_COMMIT}



api_lint_hook = ${REPO_ROOT}/frameworks/base/tools/apilint/apilint_sha.sh ${PREUPLOAD_COMMIT}



strings_lint_hook = ${REPO_ROOT}/frameworks/base/tools/stringslint/stringslint_sha.sh ${PREUPLOAD_COMMIT}



hidden_api_txt_checksorted_hook = ${REPO_ROOT}/frameworks/base/tools/hiddenapi/checksorted_sha.sh ${PREUPLOAD_COMMIT} ${REPO_ROOT}

tools/apilint/apilint

deleted100755 → 0
+0 −147
Original line number Diff line number Diff line 
#!/bin/bash



# Copyright (C) 2019 The Android Open Source Project

#

# Licensed under the Apache License, Version 2.0 (the 'License');

# you may not use this file except in compliance with the License.

# You may obtain a copy of the License at

#

#      http://www.apache.org/licenses/LICENSE-2.0

#

# Unless required by applicable law or agreed to in writing, software

# distributed under the License is distributed on an 'AS IS' BASIS,

# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

# See the License for the specific language governing permissions and

# limitations under the License.



if [ "$1" == "--help" -o "$1" == "-h" ]; then

echo "Usage: apilint [FILTERS...]"

echo "  Shows lint from currently open files (as diffed from HEAD), i.e. errors"

echo "  you will receive if you upload this CL."

echo

echo "Usage: apilint --all [FILTERS...]"

echo "  Shows all lint errors present in the current working directory, regardless"

echo "  of when they were added."

echo

echo "Usage: apilint --level API_LEVEL [FILTERS...]"

echo "  Shows lint as it stands in API_LEVEL"

echo

echo "Usage: apilint --shal SHA [FILTERS...]"

echo "  Shows lint from locally commited git change SHA."

echo

echo "Usage: apilint --unreleased [FILTERS...]"

echo "  Shows all lint errors in the current working directory directory added since"

echo "  the last released SDK version."

echo

echo "FILTERS"

echo "  List of class or package names by which to filter the results."

echo

exit

fi



if [ \( -z "$ANDROID_BUILD_TOP" \) \

           -a \( ! -f frameworks/base/api/current.txt \) \

           -a \( ! -f frameworks/base/api/system-current.txt \) \

        ]; then

    echo "apilint must be run either with ANDROID_BUILD_TOP set or from the" 1>&2

    echo "root of the android source tree" 1>&2

    exit 1

fi



if [ ${ANDROID_BUILD_TOP:0:1} != "/" ]; then

    echo "ANDROID_BUILD_TOP must be an absolute path, not: $ANDROID_BUILD_TOP" 1>&2

    exit 1

fi



if [ -z "$ANDROID_BUILD_TOP" ]; then

    ANDROID_BUILD_TOP=$(pwd)

fi



FW_BASE=$ANDROID_BUILD_TOP/frameworks/base



MODE=open



OPTIONS=$(getopt -n apilint -o "" -l "all,sha:,unreleased" -- "$@")



[ $? -eq 0 ] || { 

    exit 1

}



eval set -- "$OPTIONS"

while true; do

    case "$1" in

    --all)

        MODE=all

        ;;

    --sha)

        shift; # The arg is next in position args

        MODE=sha

        SHA=$1

        ;;

    --unreleased)

        MODE=unreleased

        ;;

    --)

        shift

        break

        ;;

    esac

    shift

done

FILTERS=

for var in "$@"

do

    FILTERS="$FILTERS --filter $var"

done



if [ $MODE = "all" ]; then

    python2.7 -B $ANDROID_BUILD_TOP/frameworks/base/tools/apilint/apilint.py \

            --title "SDK" \

            $FILTERS \

            $ANDROID_BUILD_TOP/frameworks/base/api/current.txt

    python2.7 -B $ANDROID_BUILD_TOP/frameworks/base/tools/apilint/apilint.py \

            --title "SystemApi" \

            $FILTERS \

            --base-current $ANDROID_BUILD_TOP/frameworks/base/api/current.txt \

            $ANDROID_BUILD_TOP/frameworks/base/api/system-current.txt

elif [ $MODE = "open" ]; then

    python2.7 -B $ANDROID_BUILD_TOP/frameworks/base/tools/apilint/apilint.py \

            --title "SDK" \

            $FILTERS \

            $ANDROID_BUILD_TOP/frameworks/base/api/current.txt \

            <(cd $FW_BASE ; git show HEAD:api/current.txt)

    python2.7 -B $ANDROID_BUILD_TOP/frameworks/base/tools/apilint/apilint.py \

            --title "SystemApi" \

            $FILTERS \

            --base-current $ANDROID_BUILD_TOP/frameworks/base/api/current.txt \

            --base-previous <(cd $FW_BASE ; git show HEAD:api/current.txt) \

            $ANDROID_BUILD_TOP/frameworks/base/api/system-current.txt \

            <(cd $FW_BASE ; git show HEAD:api/system-current.txt)

elif [ $MODE = "sha" ]; then

    python2.7 -B $ANDROID_BUILD_TOP/frameworks/base/tools/apilint/apilint.py \

            --title "SDK" \

            $FILTERS \

            <(cd $FW_BASE ; git show $SHA:api/current.txt) \

            <(cd $FW_BASE ; git show $SHA^:api/current.txt)

    python2.7 -B $ANDROID_BUILD_TOP/frameworks/base/tools/apilint/apilint.py \

            --title "SystemApi" \

            $FILTERS \

            --base-current <(cd $FW_BASE ; git show $SHA:api/current.txt) \

            --base-previous <(cd $FW_BASE ; git show $SHA^:api/current.txt) \

            <(cd $FW_BASE ; git show $SHA:api/system-current.txt) \

            <(cd $FW_BASE ; git show $SHA^:api/system-current.txt)

elif [ $MODE = "unreleased" ]; then

    LAST_SDK=$(ls $ANDROID_BUILD_TOP/prebuilts/sdk | grep "^[0-9][0-9]*$" | sort -n | tail -n 1)

    python2.7 -B $ANDROID_BUILD_TOP/frameworks/base/tools/apilint/apilint.py \

            --title "SDK" \

            $FILTERS \

            $ANDROID_BUILD_TOP/frameworks/base/api/current.txt \

            $ANDROID_BUILD_TOP/prebuilts/sdk/$LAST_SDK/public/api/android.txt

    python2.7 -B $ANDROID_BUILD_TOP/frameworks/base/tools/apilint/apilint.py \

            --title "SystemApi" \

            $FILTERS \

            --base-current $ANDROID_BUILD_TOP/frameworks/base/api/current.txt \

            --base-previous $ANDROID_BUILD_TOP/prebuilts/sdk/$LAST_SDK/public/api/android.txt \

            $ANDROID_BUILD_TOP/frameworks/base/api/system-current.txt \

            $ANDROID_BUILD_TOP/prebuilts/sdk/$LAST_SDK/system/api/android.txt

fi

tools/apilint/apilint.py

deleted100644 → 0
+0 −2353

File deleted.

Preview size limit exceeded, changes collapsed.

tools/apilint/apilint_sha.sh

deleted100755 → 0
+0 −4
Original line number Diff line number Diff line 
#!/bin/bash

if git show --name-only --pretty=format: $1 | grep api/ > /dev/null; then

    python tools/apilint/apilint.py <(git show $1:api/current.txt) <(git show $1^:api/current.txt)

fi

tools/apilint/apilint_sha_system.sh

deleted100755 → 0
+0 −23
Original line number Diff line number Diff line 
#!/bin/bash



# Copyright (C) 2018 The Android Open Source Project

#

# Licensed under the Apache License, Version 2.0 (the 'License');

# you may not use this file except in compliance with the License.

# You may obtain a copy of the License at

#

#      http://www.apache.org/licenses/LICENSE-2.0

#

# Unless required by applicable law or agreed to in writing, software

# distributed under the License is distributed on an 'AS IS' BASIS,

# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

# See the License for the specific language governing permissions and

# limitations under the License.



if git show --name-only --pretty=format: $1 | grep api/ > /dev/null; then

  python tools/apilint/apilint.py \

    --base-current <(git show $1:api/current.txt) \

    --base-previous <(git show $1^:api/current.txt) \

    <(git show $1:api/system-current.txt) \

    <(git show $1^:api/system-current.txt)

fi