Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d5a15143 authored by Amy's avatar Amy Committed by Amy Zhang
Browse files

Remove obsolete TODO in HDMI Framework 

Test: manual
Change-Id: Id868c4f5de4cf35d3db26ec9de7ebbdbba53af56
(cherry picked from commit 1b40d904a8fcee76f0c3bd2027edab7afbad7969)
parent 53b7e93c

services/core/java/com/android/server/hdmi/DeviceDiscoveryAction.java

+0 −1
Original line number Diff line number Diff line
@@ -335,7 +335,6 @@ final class DeviceDiscoveryAction extends HdmiCecFeatureAction { 
        current.mDeviceType = params[2] & 0xFF;

        current.mDisplayName = HdmiUtils.getDefaultDeviceName(current.mDeviceType);



        // TODO(amyjojo): check if non-TV device needs to update cec switch info.

        // This is to manager CEC device separately in case they don't have address.

        if (mIsTvDevice) {

            tv().updateCecSwitchInfo(current.mLogicalAddress, current.mDeviceType,

services/core/java/com/android/server/hdmi/HdmiCecLocalDeviceAudioSystem.java

+1 −10
Original line number Diff line number Diff line
@@ -314,7 +314,7 @@ public class HdmiCecLocalDeviceAudioSystem extends HdmiCecLocalDeviceSource { 
        super.disableDevice(initiatedByCec, callback);

        assertRunOnServiceThread();

        mService.unregisterTvInputCallback(mTvInputCallback);

        // TODO(amyjojo): check disableDevice and onStandby behaviors per spec

        // TODO(b/129088603): check disableDevice and onStandby behaviors per spec

    }



    @Override
@@ -463,15 +463,6 @@ public class HdmiCecLocalDeviceAudioSystem extends HdmiCecLocalDeviceSource { 
        return true;

    }



    @Override

    @ServiceThreadOnly

    protected boolean handleReportAudioStatus(HdmiCecMessage message) {

        assertRunOnServiceThread();

        // TODO(amyjojo): implement report audio status handler

        HdmiLogger.debug(TAG + "Stub handleReportAudioStatus");

        return true;

    }



    @Override

    @ServiceThreadOnly

    protected boolean handleInitiateArc(HdmiCecMessage message) {

services/core/java/com/android/server/hdmi/HdmiControlService.java

+1 −1
Original line number Diff line number Diff line
@@ -1764,7 +1764,7 @@ public class HdmiControlService extends SystemService { 
        }



        @Override

        // TODO(AMYJOJO): add a result callback

        // TODO(b/128427908): add a result callback

        public void askRemoteDeviceToBecomeActiveSource(int physicalAddress) {

            enforceAccessPermission();

            runOnServiceThread(new Runnable() {