Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d53e3bed authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

Fix google-explicit-constructor warnings. 

Bug: 28341362
Change-Id: I080090d50f1a368a4e7c1a0732297bb6a295e34f
parent 5b93c24b

core/jni/android_view_ThreadedRenderer.cpp

+1 −1
Original line number Diff line number Diff line
@@ -80,7 +80,7 @@ void onRenderNodeRemoved(JNIEnv* env, RenderNode* node); 


class ScopedRemovedRenderNodeObserver : public TreeObserver {

public:

    ScopedRemovedRenderNodeObserver(JNIEnv* env) : mEnv(env) {}

    explicit ScopedRemovedRenderNodeObserver(JNIEnv* env) : mEnv(env) {}

    ~ScopedRemovedRenderNodeObserver() {

        for (auto& node : mMaybeRemovedNodes) {

            if (node->hasParents()) continue;

libs/hwui/renderthread/CanvasContext.cpp

+1 −1
Original line number Diff line number Diff line
@@ -762,7 +762,7 @@ void CanvasContext::waitOnFences() { 


class CanvasContext::FuncTaskProcessor : public TaskProcessor<bool> {

public:

    FuncTaskProcessor(Caches& caches)

    explicit FuncTaskProcessor(Caches& caches)

            : TaskProcessor<bool>(&caches.tasks) {}



    virtual void onProcess(const sp<Task<bool> >& task) override {

libs/hwui/tests/macrobench/TestSceneRunner.cpp

+1 −1
Original line number Diff line number Diff line
@@ -41,7 +41,7 @@ public: 
template<class T>

class ModifiedMovingAverage {

public:

    ModifiedMovingAverage(int weight) : mWeight(weight) {}

    explicit ModifiedMovingAverage(int weight) : mWeight(weight) {}



    T add(T today) {

        if (!mHasValue) {

libs/hwui/tests/microbench/TaskManagerBench.cpp

+1 −1
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ class TrivialTask : public Task<char> {}; 


class TrivialProcessor : public TaskProcessor<char> {

public:

    TrivialProcessor(TaskManager* manager)

    explicit TrivialProcessor(TaskManager* manager)

            : TaskProcessor(manager) {}

    virtual ~TrivialProcessor() {}

    virtual void onProcess(const sp<Task<char> >& task) override {

libs/hwui/tests/unit/FrameBuilderTests.cpp

+2 −2
Original line number Diff line number Diff line
@@ -1919,7 +1919,7 @@ static void testProperty(std::function<void(RenderProperties&)> propSetupCallbac 
        std::function<void(const RectOp&, const BakedOpState&)> opValidateCallback) {

    class PropertyTestRenderer : public TestRendererBase {

    public:

        PropertyTestRenderer(std::function<void(const RectOp&, const BakedOpState&)> callback)

        explicit PropertyTestRenderer(std::function<void(const RectOp&, const BakedOpState&)> callback)

                : mCallback(callback) {}

        void onRectOp(const RectOp& op, const BakedOpState& state) override {

            EXPECT_EQ(mIndex++, 0);
@@ -2040,7 +2040,7 @@ void testSaveLayerAlphaClip(SaveLayerAlphaData* outObservedData, 
        std::function<void(RenderProperties&)> propSetupCallback) {

    class SaveLayerAlphaClipTestRenderer : public TestRendererBase {

    public:

        SaveLayerAlphaClipTestRenderer(SaveLayerAlphaData* outData)

        explicit SaveLayerAlphaClipTestRenderer(SaveLayerAlphaData* outData)

                : mOutData(outData) {}



        OffscreenBuffer* startTemporaryLayer(uint32_t width, uint32_t height) override {