am 2325fd5d: am 4ef2693a: Revert back to a single home app in mHomeProcess (d4338177) · Commits · e / os / android_frameworks_base

services/java/com/android/server/am/ActivityManagerService.java

+18 −29

Original line number	Diff line number	Diff line
		@@ -21,12 +21,12 @@ import static com.android.internal.util.XmlUtils.readIntAttribute;
		import static com.android.internal.util.XmlUtils.writeIntAttribute;
		import static org.xmlpull.v1.XmlPullParser.END_DOCUMENT;
		import static org.xmlpull.v1.XmlPullParser.START_TAG;

		import static com.android.server.am.ActivityStackSupervisor.HOME_STACK_ID;

		import android.app.AppOpsManager;
		import android.appwidget.AppWidgetManager;
		import android.util.ArrayMap;

		import com.android.internal.R;
		import com.android.internal.annotations.GuardedBy;
		import com.android.internal.app.IAppOpsService;
		@@ -52,7 +52,6 @@ import com.android.server.pm.UserManagerService;
		import com.android.server.wm.AppTransition;
		import com.android.server.wm.StackBox;
		import com.android.server.wm.WindowManagerService;

		import com.google.android.collect.Lists;
		import com.google.android.collect.Maps;

		@@ -155,7 +154,6 @@ import android.os.UpdateLock;
		import android.os.UserHandle;
		import android.provider.Settings;
		import android.text.format.Time;
		import android.util.ArraySet;
		import android.util.AtomicFile;
		import android.util.EventLog;
		import android.util.Log;
		@@ -519,7 +517,7 @@ public final class ActivityManagerService extends ActivityManagerNative
		* This is the process holding what we currently consider to be
		* the "home" activity.
		*/
		ArraySet<ProcessRecord> mHomeProcess = new ArraySet<ProcessRecord>();
		ProcessRecord mHomeProcess;

		/**
		* This is the process holding the activity the user last visited that
		@@ -9126,8 +9124,8 @@ public final class ActivityManagerService extends ActivityManagerNative
		// with a home activity running in the process to prevent a repeatedly crashing app
		// from blocking the user to manually clear the list.
		final ArrayList<ActivityRecord> activities = app.activities;
		if (mHomeProcess.contains(app) && activities.size() > 0
		&& (app.info.flags & ApplicationInfo.FLAG_SYSTEM) == 0) {
		if (app == mHomeProcess && activities.size() > 0
		&& (mHomeProcess.info.flags & ApplicationInfo.FLAG_SYSTEM) == 0) {
		for (int activityNdx = activities.size() - 1; activityNdx >= 0; --activityNdx) {
		final ActivityRecord r = activities.get(activityNdx);
		if (r.isHomeActivity()) {
		@@ -10404,20 +10402,13 @@ public final class ActivityManagerService extends ActivityManagerNative
		pw.print(" mStartedUserArray: "); pw.println(Arrays.toString(mStartedUserArray));
		}
		}
		if (!mHomeProcess.isEmpty()) {
		final int size = mHomeProcess.size();
		ProcessRecord[] processes = new ProcessRecord[size];
		mHomeProcess.toArray(processes);
		for (int processNdx = 0; processNdx < size; ++processNdx) {
		final ProcessRecord app = processes[processNdx];
		if (dumpPackage == null \|\| app.pkgList.containsKey(dumpPackage)) {
		if (mHomeProcess != null && (dumpPackage == null
		\|\| mHomeProcess.pkgList.containsKey(dumpPackage))) {
		if (needSep) {
		pw.println();
		needSep = false;
		}
		pw.println(" mHomeProcess[" + processNdx + "]: " + app);
		}
		}
		pw.println(" mHomeProcess: " + mHomeProcess);
		}
		if (mPreviousProcess != null && (dumpPackage == null
		\|\| mPreviousProcess.pkgList.containsKey(dumpPackage))) {
		@@ -11948,8 +11939,6 @@ public final class ActivityManagerService extends ActivityManagerNative
		}
		mHandler.obtainMessage(DISPATCH_PROCESS_DIED, app.pid, app.info.uid, null).sendToTarget();

		mHomeProcess.remove(app);

		// If the caller is restarting this app, then leave it in its
		// current lists and let the caller take care of it.
		if (restarting) {
		@@ -11979,8 +11968,8 @@ public final class ActivityManagerService extends ActivityManagerNative
		"Clean-up removing on hold: " + app);
		mProcessesOnHold.remove(app);

		if (mHomeProcess.contains(app)) {
		mHomeProcess.remove(app);
		if (app == mHomeProcess) {
		mHomeProcess = null;
		}
		if (app == mPreviousProcess) {
		mPreviousProcess = null;
		@@ -13909,7 +13898,7 @@ public final class ActivityManagerService extends ActivityManagerNative
		}
		}

		if (mHomeProcess.contains(app)) {
		if (app == mHomeProcess) {
		if (adj > ProcessList.HOME_APP_ADJ) {
		// This process is hosting what we currently consider to be the
		// home app, so we don't want to let it go into the background.
		@@ -13976,7 +13965,7 @@ public final class ActivityManagerService extends ActivityManagerNative
		if (procState > ActivityManager.PROCESS_STATE_SERVICE) {
		procState = ActivityManager.PROCESS_STATE_SERVICE;
		}
		if (app.hasShownUi && !mHomeProcess.contains(app)) {
		if (app.hasShownUi && app != mHomeProcess) {
		// If this process has shown some UI, let it immediately
		// go to the LRU list because it may be pretty heavy with
		// UI stuff. We'll tag it with a label just to help
		@@ -14039,7 +14028,7 @@ public final class ActivityManagerService extends ActivityManagerNative
		if ((cr.flags&Context.BIND_ALLOW_OOM_MANAGEMENT) != 0) {
		// Not doing bind OOM management, so treat
		// this guy more like a started service.
		if (app.hasShownUi && !mHomeProcess.contains(app)) {
		if (app.hasShownUi && app != mHomeProcess) {
		// If this process has shown some UI, let it immediately
		// go to the LRU list because it may be pretty heavy with
		// UI stuff. We'll tag it with a label just to help
		@@ -14094,7 +14083,7 @@ public final class ActivityManagerService extends ActivityManagerNative
		// about letting this process get into the LRU
		// list to be killed and restarted if needed for
		// memory.
		if (app.hasShownUi && !mHomeProcess.contains(app)
		if (app.hasShownUi && app != mHomeProcess
		&& clientAdj > ProcessList.PERCEPTIBLE_APP_ADJ) {
		adjType = "cch-bound-ui-services";
		} else {
		@@ -14208,7 +14197,7 @@ public final class ActivityManagerService extends ActivityManagerNative
		clientProcState = ActivityManager.PROCESS_STATE_CACHED_EMPTY;
		}
		if (adj > clientAdj) {
		if (app.hasShownUi && !mHomeProcess.contains(app)
		if (app.hasShownUi && app != mHomeProcess
		&& clientAdj > ProcessList.PERCEPTIBLE_APP_ADJ) {
		app.adjType = "cch-ui-provider";
		} else {
		@@ -15067,7 +15056,7 @@ public final class ActivityManagerService extends ActivityManagerNative
		// to be good enough at this point that destroying
		// activities causes more harm than good.
		if (curLevel >= ComponentCallbacks2.TRIM_MEMORY_COMPLETE
		&& !mHomeProcess.contains(app) && app != mPreviousProcess) {
		&& app != mHomeProcess && app != mPreviousProcess) {
		// Need to do this on its own message because the stack may not
		// be in a consistent state at this point.
		// For these apps we will also finish their activities

services/java/com/android/server/am/ActivityStack.java

+1 −1

Original line number	Diff line number	Diff line
		@@ -2254,7 +2254,7 @@ final class ActivityStack {
		if (r.state == ActivityState.RESUMED
		\|\| r.state == ActivityState.PAUSING
		\|\| r.state == ActivityState.PAUSED) {
		if (!r.isHomeActivity() \|\| !mService.mHomeProcess.contains(r.app)) {
		if (!r.isHomeActivity() \|\| mService.mHomeProcess != r.app) {
		Slog.w(TAG, " Force finishing activity "
		+ r.intent.getComponent().flattenToShortString());
		finishActivityLocked(r, Activity.RESULT_CANCELED, null, "crashed", false);

services/java/com/android/server/am/ActivityStackSupervisor.java

+3 −2

Original line number	Diff line number	Diff line
		@@ -906,7 +906,8 @@ public final class ActivityStackSupervisor {
		r.task.taskId, r.shortComponentName);
		}
		if (r.isHomeActivity() && r.isNotResolverActivity()) {
		mService.mHomeProcess.add(app);
		// Home process is the root process of the task.
		mService.mHomeProcess = r.task.mActivities.get(0).app;
		}
		mService.ensurePackageDexOpt(r.intent.getComponent().getPackageName());
		r.sleeping = false;
		@@ -1949,7 +1950,7 @@ public final class ActivityStackSupervisor {
		// makes sense to.
		if (r.app != null && fgApp != null && r.app != fgApp
		&& r.lastVisibleTime > mService.mPreviousProcessVisibleTime
		&& !mService.mHomeProcess.contains(r.app)) {
		&& r.app != mService.mHomeProcess) {
		mService.mPreviousProcess = r.app;
		mService.mPreviousProcessVisibleTime = r.lastVisibleTime;
		}