Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d23b5379 authored by Jeff Sharkey's avatar Jeff Sharkey
Browse files

Enable Error Prone to detect obscure bugs. 

We've been writing many new framework-specific Error Prone checkers
to help detect obscure platform bugs, and this change starts enabling
those checkers for more packages across the platform.

Bug: 155703208
Test: manual
Exempt-From-Owner-Approval: trivial blueprint changes
Change-Id: I1db3412b0be40f6f78c68331ae01756887192071
parent c76708bc

Android.bp

+31 −0
Original line number Original line Diff line number Diff line
@@ -14,6 +14,37 @@ 




// Build the master framework library.

// Build the master framework library.





// Defaults for platform code that runs inside system_server

java_defaults {

    name: "platform_service_defaults",

    plugins: [

        "error_prone_android_framework",

    ],

    errorprone: {

        javacflags: [

            "-Xep:AndroidFrameworkBinderIdentity:ERROR",

            "-Xep:AndroidFrameworkCompatChange:ERROR",

            "-Xep:AndroidFrameworkUid:ERROR",

        ],

    },

}



// Defaults for platform apps

java_defaults {

    name: "platform_app_defaults",

    plugins: [

        "error_prone_android_framework",

    ],

    errorprone: {

        javacflags: [

            // We're less worried about performance in app code

            "-Xep:AndroidFrameworkEfficientCollections:OFF",

            "-Xep:AndroidFrameworkEfficientParcelable:OFF",

            "-Xep:AndroidFrameworkEfficientStrings:OFF",

        ],

    },

}



// READ ME: ########################################################

// READ ME: ########################################################

//

//

// When updating this list of aidl files, consider if that aidl is

// When updating this list of aidl files, consider if that aidl is

packages/BackupEncryption/Android.bp

+1 −0
Original line number Original line Diff line number Diff line
@@ -16,6 +16,7 @@ 




android_app {

android_app {

    name: "BackupEncryption",

    name: "BackupEncryption",

    defaults: ["platform_app_defaults"],

    srcs: ["src/**/*.java"],

    srcs: ["src/**/*.java"],

    static_libs: ["backup-encryption-protos", "backuplib"],

    static_libs: ["backup-encryption-protos", "backuplib"],

    optimize: { enabled: false },

    optimize: { enabled: false },

packages/BackupRestoreConfirmation/Android.bp

+1 −0
Original line number Original line Diff line number Diff line
@@ -16,6 +16,7 @@ 




android_app {

android_app {

    name: "BackupRestoreConfirmation",

    name: "BackupRestoreConfirmation",

    defaults: ["platform_app_defaults"],

    srcs: ["src/**/*.java"],

    srcs: ["src/**/*.java"],

    platform_apis: true,

    platform_apis: true,

    certificate: "platform",

    certificate: "platform",

packages/CompanionDeviceManager/Android.bp

+1 −0
Original line number Original line Diff line number Diff line
@@ -14,6 +14,7 @@ 




android_app {

android_app {

    name: "CompanionDeviceManager",

    name: "CompanionDeviceManager",

    defaults: ["platform_app_defaults"],

    srcs: ["src/**/*.java"],

    srcs: ["src/**/*.java"],





    platform_apis: true,

    platform_apis: true,

packages/DynamicSystemInstallationService/Android.bp

+1 −0
Original line number Original line Diff line number Diff line 
android_app {

android_app {

    name: "DynamicSystemInstallationService",

    name: "DynamicSystemInstallationService",

    defaults: ["platform_app_defaults"],





    srcs: ["src/**/*.java"],

    srcs: ["src/**/*.java"],

    resource_dirs: ["res"],

    resource_dirs: ["res"],