Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d153d5fd authored by nathch's avatar nathch
Browse files

Avoid warning logs on blocking Binder calls out of system_server to IBackupTransport 

The implementations of IBackupTransport are whitelisted therefore in the short-term,
its OK to allow these calls and avoid the warning logs which can be distracting when
looking at logs to investigate bugs and are not of any real value since we are already
aware of this.

Bug: 148783926

Test: atest -v CtsBackupTestCases
Test: atest -v CtsBackupHostTestCases
Change-Id: I13e2a638891d0369310bc2c665fa772306a28199
parent f96fed1d

services/backup/backuplib/java/com/android/server/backup/transport/TransportClient.java

+5 −0
Original line number Diff line number Diff line
@@ -26,6 +26,7 @@ import android.content.ComponentName; 
import android.content.Context;

import android.content.Intent;

import android.content.ServiceConnection;

import android.os.Binder;

import android.os.DeadObjectException;

import android.os.Handler;

import android.os.IBinder;
@@ -662,6 +663,10 @@ public class TransportClient { 
                referenceLost("TransportConnection.onServiceConnected()");

                return;

            }

            // TODO (b/147705255): Remove when binder calls to IBackupTransport are not blocking

            // In short-term, blocking calls are OK as the transports come from the whitelist at

            // {@link SystemConfig#getBackupTransportWhitelist()}

            Binder.allowBlocking(binder);

            transportClient.onServiceConnected(binder);

        }