Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0ea5b4a authored by Luca Zuccarini's avatar Luca Zuccarini
Browse files

Clean up aconfig flag fix_dialog_launch_animation_jank_logging. 

Fix: 429244514
Flag: EXEMPT flag cleanup
Test: EXEMPT flag cleanup
Change-Id: I60d3030d3e8b007be119a508c9bf71c3eb22ac73
parent 388f0cd6

packages/SystemUI/aconfig/systemui.aconfig

+0 −10
Original line number Diff line number Diff line
@@ -1932,16 +1932,6 @@ flag { 
    bug: "430582532"

}



flag {

    name: "fix_dialog_launch_animation_jank_logging"

    namespace: "systemui"

    description: "Adjust timing of jank logging for dialog launch animations, and attach it to the dialog window instead of the origin view window."

    bug: "409008342"

    metadata {

        purpose: PURPOSE_BUGFIX

    }

}



flag {

    name: "animation_library_delay_leash_cleanup"

    namespace: "systemui"

packages/SystemUI/animation/src/com/android/systemui/animation/DialogTransitionAnimator.kt

+6 −23
Original line number Diff line number Diff line
@@ -577,21 +577,6 @@ private class AnimatedDialog( 
    private var hasInstrumentedJank = false



    fun start() {

        if (!Flags.fixDialogLaunchAnimationJankLogging()) {

            val cuj = controller.cuj

            if (cuj != null) {

                val config = controller.jankConfigurationBuilder()

                if (config != null) {

                    if (cuj.tag != null) {

                        config.setTag(cuj.tag)

                    }



                    interactionJankMonitor.begin(config)

                    hasInstrumentedJank = true

                }

            }

        }



        // Create the dialog so that its onCreate() method is called, which usually sets the dialog

        // content.

        dialog.create()
@@ -787,7 +772,6 @@ private class AnimatedDialog( 
            return

        }



        if (Flags.fixDialogLaunchAnimationJankLogging()) {

        controller.cuj?.let { cuj ->

            val config =

                InteractionJankMonitor.Configuration.Builder.withView(cuj.cujType, decorView)
@@ -795,7 +779,6 @@ private class AnimatedDialog( 
            interactionJankMonitor.begin(config)

            hasInstrumentedJank = true

        }

        }



        // Show the background dim.

        dialog.window?.addFlags(WindowManager.LayoutParams.FLAG_DIM_BEHIND)