Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0c225cc authored by Wale Ogunwale's avatar Wale Ogunwale
Browse files

Removed TODO introduced in ag/4344061 

After further digging, we determined that the workaround is the
best way forward.

Change-Id: If046cdd16a22f0eec63a611eb21ce5e4c875896d
Fixes: 110159357
Test: N/A
parent b44f8b9e

services/core/java/com/android/server/wm/DisplayContent.java

+3 −7
Original line number Diff line number Diff line
@@ -3535,15 +3535,11 @@ class DisplayContent extends WindowContainer<DisplayContent.DisplayChildWindowCo 
            if (isStackVisible(WINDOWING_MODE_SPLIT_SCREEN_PRIMARY)

                    || isStackVisible(WINDOWING_MODE_FREEFORM)) {

                // Apps and their containers are not allowed to specify an orientation while the

                // docked or freeform stack is visible...except for the home stack/task if the

                // docked stack is minimized and it actually set something.

                // docked or freeform stack is visible...except for the home stack if the docked

                // stack is minimized and it actually set something and the bounds is different from

                // the display.

                if (mHomeStack != null && mHomeStack.isVisible()

                        && mDividerControllerLocked.isMinimizedDock()

                        // TODO(b/110159357): Work around to unblock the release for failing test

                        // ActivityManagerAppConfigurationTests#testSplitscreenPortraitAppOrientationRequests

                        // which shouldn't be failing since home stack shouldn't be visible. We need

                        // to dig deeper to see why it is failing. NOTE: Not failing on current

                        // master...

                        && !(mDividerControllerLocked.isHomeStackResizable()

                            && mHomeStack.matchParentBounds())) {

                    final int orientation = mHomeStack.getOrientation();