Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d041822f authored by Amith Yamasani's avatar Amith Yamasani
Browse files

Reduce wtf spam when a service onDestroy races with proc death 

Only log a message if the ServiceRecord still has a non-null app

Bug: 28527548
Change-Id: I737679a6a0cd28d265919090c6a9e955ee454379
parent 67b98daa

services/core/java/com/android/server/am/ActiveServices.java

+6 −2
Original line number Diff line number Diff line
@@ -2186,8 +2186,12 @@ public final class ActiveServices { 
                if (!inDestroying) {

                    // Not sure what else to do with this...  if it is not actually in the

                    // destroying list, we don't need to make sure to remove it from it.

                    // If the app is null, then it was probably removed because the process died,

                    // otherwise wtf

                    if (r.app != null) {

                        Slog.wtfStack(TAG, "Service done with onDestroy, but not inDestroying: "

                            + r);

                                + r + ", app=" + r.app);

                    }

                } else if (r.executeNesting != 1) {

                    Slog.wtfStack(TAG, "Service done with onDestroy, but executeNesting="

                            + r.executeNesting + ": " + r);