Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cfde15d7 authored by Glenn Kasten's avatar Glenn Kasten
Browse files

Document that ByteBuffer position not updated 

This behavior is perhaps unfortunate but could cause compatibility
problems if it were changed at this point.

Bug: 7479782
Change-Id: I1ea0f1c8d5277c509cbea199f3c24a1563bcb2d0
parent cf27115a

core/java/android/hardware/SerialPort.java

+6 −2
Original line number Diff line number Diff line
@@ -82,7 +82,9 @@ public class SerialPort { 
    }



    /**

     * Reads data into the provided buffer

     * Reads data into the provided buffer.

     * Note that the value returned by {@link java.nio.Buffer#position()} on this buffer is

     * unchanged after a call to this method.

     *

     * @param buffer to read into

     * @return number of bytes read
@@ -98,7 +100,9 @@ public class SerialPort { 
    }



    /**

     * Writes data from provided buffer

     * Writes data from provided buffer.

     * Note that the value returned by {@link java.nio.Buffer#position()} on this buffer is

     * unchanged after a call to this method.

     *

     * @param buffer to write

     * @param length number of bytes to write

media/java/android/media/AudioRecord.java

+2 −0
Original line number Diff line number Diff line
@@ -618,6 +618,8 @@ public class AudioRecord 
    /**

     * Reads audio data from the audio hardware for recording into a direct buffer. If this buffer

     * is not a direct buffer, this method will always return 0.

     * Note that the value returned by {@link java.nio.Buffer#position()} on this buffer is

     * unchanged after a call to this method.

     * @param audioBuffer the direct buffer to which the recorded audio data is written.

     * @param sizeInBytes the number of requested bytes.

     * @return the number of bytes that were read or or {@link #ERROR_INVALID_OPERATION}