Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit cfd3c5b4 authored by Hongwei Wang's avatar Hongwei Wang Committed by Android Build Coastguard Worker
Browse files

Ensure onStop before onPictureInPictureModeChanged

We have a CTS test case
PinnedStackTests#testStopBeforeMultiWindowCallbacksOnDismiss that
ensures onStop is always sent before onPictureInPictureModeChanged. The
test itself does not simulate what user typically does and it's broken
with the shell transition.

Apps like YouTube may rely on such order so they can choose if they
should, for instance, stop the playback when the PiP is removed.

Fixing this by forcefully send onStop before setWindowingMode (which in
turn results a configuration change).

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/eEEfu9mca0dzLyzC8jBcxb
Bug: 290413333
Test: manually, see also the video
Test: atest PinnedStackTests
(cherry picked from commit 59c5d810)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3dfe4c8e0955809ef96b1e89b87f9cabb9046b91)
Merged-In: I0f94d4c26f7b3ccc1df6be97a0238f995438dffd
Change-Id: I0f94d4c26f7b3ccc1df6be97a0238f995438dffd
parent 1dd37363
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment