Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf95e250 authored by Behnam Heydarshahi's avatar Behnam Heydarshahi
Browse files

Use groove for volume dialog slider 

Previously we had a track line that stopped below the max val, creating
the illusion that at ~90%, volume level is full. It looked misaligned
next to a 100% slider.

Bug: b/289814874
Test: Manual. Groove height should match progress button at 100%.
Change-Id: Ifd2d7acdac7b6a154728536b096ac0dbd1d40b3d
parent d74e3d74

packages/SystemUI/res/drawable/volume_row_seekbar.xml

+6 −9
Original line number Diff line number Diff line
@@ -20,17 +20,14 @@ 
<layer-list xmlns:android="http://schemas.android.com/apk/res/android"

    xmlns:androidprv="http://schemas.android.com/apk/prv/res/android"

    android:paddingMode="stack" >

    <!-- The groove used for indicating max volume !-->

    <item android:id="@android:id/background"

        android:gravity="center_vertical|fill_horizontal">

        <inset

            android:insetLeft="@dimen/rounded_slider_track_inset"

            android:insetRight="@dimen/rounded_slider_track_inset" >

        <shape>

            <size android:height="@dimen/volume_dialog_track_width" />

                <corners android:radius="@dimen/volume_dialog_track_corner_radius" />

                <solid android:color="?androidprv:attr/colorAccentSecondaryVariant" />

            <corners android:radius="@dimen/volume_dialog_panel_width_half" />

            <solid android:color="?androidprv:attr/materialColorOutlineVariant" />

        </shape>

        </inset>

    </item>

    <item android:id="@android:id/progress"

        android:gravity="center_vertical|fill_horizontal">

packages/SystemUI/res/values/dimens.xml

+1 −1
Original line number Diff line number Diff line
@@ -545,7 +545,7 @@ 
    <!-- (volume_dialog_panel_width - rounded_slider_icon_size) / 2 -->

    <dimen name="volume_slider_icon_inset">11dp</dimen>



    <dimen name="volume_dialog_track_width">4dp</dimen>

    <dimen name="volume_dialog_track_width">40dp</dimen>



    <dimen name="volume_dialog_track_corner_radius">2dp</dimen>