Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf585956 authored by Ted Bauer's avatar Ted Bauer
Browse files

Make device_config clear_override take effect immediately. 

Flag: com.android.aconfig_new_storage.support_clear_local_overrides_immediately
Bug: 360205436
Change-Id: Ib8b012f3dd9faae6ae9802ab6afc29b17dd3e5d9
Test: flexiglass reset
parent ea6fd957

services/core/java/com/android/server/am/SettingsToPropertiesMapper.java

+15 −3
Original line number Diff line number Diff line
@@ -41,6 +41,7 @@ import android.aconfigd.Aconfigd.StorageReturnMessage; 
import android.aconfigd.Aconfigd.StorageReturnMessages;

import static com.android.aconfig_new_storage.Flags.enableAconfigStorageDaemon;

import static com.android.aconfig_new_storage.Flags.supportImmediateLocalOverrides;

import static com.android.aconfig_new_storage.Flags.supportClearLocalOverridesImmediately;



import java.io.DataInputStream;

import java.io.DataOutputStream;
@@ -525,14 +526,21 @@ public class SettingsToPropertiesMapper { 
     * @param proto

     * @param packageName the package of the flag

     * @param flagName the name of the flag

     * @param immediate if true, clear immediately; otherwise, clear on next reboot

     *

     * @hide

     */

    static void writeFlagOverrideRemovalRequest(

        ProtoOutputStream proto, String packageName, String flagName) {

    public static void writeFlagOverrideRemovalRequest(

        ProtoOutputStream proto, String packageName, String flagName, boolean immediate) {

      long msgsToken = proto.start(StorageRequestMessages.MSGS);

      long msgToken = proto.start(StorageRequestMessage.REMOVE_LOCAL_OVERRIDE_MESSAGE);

      proto.write(StorageRequestMessage.RemoveLocalOverrideMessage.PACKAGE_NAME, packageName);

      proto.write(StorageRequestMessage.RemoveLocalOverrideMessage.FLAG_NAME, flagName);

      proto.write(StorageRequestMessage.RemoveLocalOverrideMessage.REMOVE_ALL, false);

      proto.write(StorageRequestMessage.RemoveLocalOverrideMessage.REMOVE_OVERRIDE_TYPE,

          immediate

              ? StorageRequestMessage.REMOVE_LOCAL_IMMEDIATE

              : StorageRequestMessage.REMOVE_LOCAL_ON_REBOOT);

      proto.end(msgToken);

      proto.end(msgsToken);

    }
@@ -609,7 +617,11 @@ public class SettingsToPropertiesMapper { 
            String realFlagName = fullFlagName.substring(idx+1);



            if (Flags.syncLocalOverridesRemovalNewStorage() && flagValue == null) {

              writeFlagOverrideRemovalRequest(requests, packageName, realFlagName);

              if (supportClearLocalOverridesImmediately()) {

                writeFlagOverrideRemovalRequest(requests, packageName, realFlagName, true);

              } else {

                writeFlagOverrideRemovalRequest(requests, packageName, realFlagName, false);

              }

            } else {

              writeFlagOverrideRequest(requests, packageName, realFlagName, flagValue, true);

            }