Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ced3c22d authored by Eric Laurent's avatar Eric Laurent
Browse files

AudioDeviceInventory: add cache for preferred device roles 

Add a cache for the last selected devices role (disabled/preferred)
for any strategy or capture preset.
This avoids redundant and frequent rerouting requests sent to audio
policy manager causing delays and glitches in audio playback and
capture.

Bug: 276386807
Bug: 265077417
Test: atest NonDefaultDeviceForStrategyTest
Test: atest AudioManagerTest#testPreferredDevicesForStrategy
Test: atest AudioManagerTest#testPreferredDeviceForCapturePreset

Change-Id: Id3e9efe1277b41c94a799e032148574da85f5ea7
parent 4048e343

services/core/java/com/android/server/audio/AudioDeviceBroker.java

+12 −12
Original line number Diff line number Diff line
@@ -1092,21 +1092,21 @@ import java.util.concurrent.atomic.AtomicBoolean; 


    /*package*/ int setPreferredDevicesForStrategySync(int strategy,

            @NonNull List<AudioDeviceAttributes> devices) {

        return mDeviceInventory.setPreferredDevicesForStrategySync(strategy, devices);

        return mDeviceInventory.setPreferredDevicesForStrategyAndSave(strategy, devices);

    }



    /*package*/ int removePreferredDevicesForStrategySync(int strategy) {

        return mDeviceInventory.removePreferredDevicesForStrategySync(strategy);

        return mDeviceInventory.removePreferredDevicesForStrategyAndSave(strategy);

    }



    /*package*/ int setDeviceAsNonDefaultForStrategySync(int strategy,

            @NonNull AudioDeviceAttributes device) {

        return mDeviceInventory.setDeviceAsNonDefaultForStrategySync(strategy, device);

        return mDeviceInventory.setDeviceAsNonDefaultForStrategyAndSave(strategy, device);

    }



    /*package*/ int removeDeviceAsNonDefaultForStrategySync(int strategy,

            @NonNull AudioDeviceAttributes device) {

        return mDeviceInventory.removeDeviceAsNonDefaultForStrategySync(strategy, device);

        return mDeviceInventory.removeDeviceAsNonDefaultForStrategyAndSave(strategy, device);

    }



    /*package*/ void registerStrategyPreferredDevicesDispatcher(
@@ -1131,11 +1131,11 @@ import java.util.concurrent.atomic.AtomicBoolean; 


    /*package*/ int setPreferredDevicesForCapturePresetSync(int capturePreset,

            @NonNull List<AudioDeviceAttributes> devices) {

        return mDeviceInventory.setPreferredDevicesForCapturePresetSync(capturePreset, devices);

        return mDeviceInventory.setPreferredDevicesForCapturePresetAndSave(capturePreset, devices);

    }



    /*package*/ int clearPreferredDevicesForCapturePresetSync(int capturePreset) {

        return mDeviceInventory.clearPreferredDevicesForCapturePresetSync(capturePreset);

        return mDeviceInventory.clearPreferredDevicesForCapturePresetAndSave(capturePreset);

    }



    /*package*/ void registerCapturePresetDevicesRoleDispatcher(
@@ -2165,18 +2165,18 @@ import java.util.concurrent.atomic.AtomicBoolean; 
        if (preferredCommunicationDevice == null) {

            AudioDeviceAttributes defaultDevice = getDefaultCommunicationDevice();

            if (defaultDevice != null) {

                setPreferredDevicesForStrategySync(

                mDeviceInventory.setPreferredDevicesForStrategy(

                        mCommunicationStrategyId, Arrays.asList(defaultDevice));

                setPreferredDevicesForStrategySync(

                mDeviceInventory.setPreferredDevicesForStrategy(

                        mAccessibilityStrategyId, Arrays.asList(defaultDevice));

            } else {

                removePreferredDevicesForStrategySync(mCommunicationStrategyId);

                removePreferredDevicesForStrategySync(mAccessibilityStrategyId);

                mDeviceInventory.removePreferredDevicesForStrategy(mCommunicationStrategyId);

                mDeviceInventory.removePreferredDevicesForStrategy(mAccessibilityStrategyId);

            }

        } else {

            setPreferredDevicesForStrategySync(

            mDeviceInventory.setPreferredDevicesForStrategy(

                    mCommunicationStrategyId, Arrays.asList(preferredCommunicationDevice));

            setPreferredDevicesForStrategySync(

            mDeviceInventory.setPreferredDevicesForStrategy(

                    mAccessibilityStrategyId, Arrays.asList(preferredCommunicationDevice));

        }

        onUpdatePhoneStrategyDevice(preferredCommunicationDevice);

services/core/java/com/android/server/audio/AudioDeviceInventory.java

+301 −35

File changed.

Preview size limit exceeded, changes collapsed.

services/core/java/com/android/server/audio/AudioSystemAdapter.java

+14 −1

File changed.

Preview size limit exceeded, changes collapsed.