Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ceb54c63 authored by Erik Kline's avatar Erik Kline
Browse files

Switch to WifiManager.{start,stop}SoftAp() 

Test: as follows
    - built
    - flashed
    - booted
    - "runtest frameworks-net" passes
Bug: 31466854

Change-Id: I730d029128a14b936c111ae159b9708d935f4656
parent 6d033475

services/core/java/com/android/server/connectivity/Tethering.java

+2 −1
Original line number Diff line number Diff line
@@ -413,7 +413,8 @@ public class Tethering extends BaseNetworkObserver implements IControlsTethering 
            mWifiTetherRequested = enable;

            final WifiManager wifiManager =

                    (WifiManager) mContext.getSystemService(Context.WIFI_SERVICE);

            if (wifiManager.setWifiApEnabled(null /* use existing wifi config */, enable)) {

            if ((enable && wifiManager.startSoftAp(null /* use existing wifi config */)) ||

                (!enable && wifiManager.stopSoftAp())) {

                return ConnectivityManager.TETHER_ERROR_NO_ERROR;

            }

            return ConnectivityManager.TETHER_ERROR_MASTER_ERROR;

tests/net/java/com/android/server/connectivity/TetheringTest.java

+3 −6
Original line number Diff line number Diff line
@@ -183,8 +183,6 @@ public class TetheringTest { 
    @Test

    public void workingLocalOnlyHotspot() throws Exception {

        when(mConnectivityManager.isTetheringSupported()).thenReturn(true);

        when(mWifiManager.setWifiApEnabled(any(WifiConfiguration.class), anyBoolean()))

                .thenReturn(true);



        // Emulate externally-visible WifiManager effects, causing the

        // per-interface state machine to start up, and telling us that
@@ -234,13 +232,12 @@ public class TetheringTest { 
    @Test

    public void workingWifiTethering() throws Exception {

        when(mConnectivityManager.isTetheringSupported()).thenReturn(true);

        when(mWifiManager.setWifiApEnabled(any(WifiConfiguration.class), anyBoolean()))

                .thenReturn(true);

        when(mWifiManager.startSoftAp(any(WifiConfiguration.class))).thenReturn(true);



        // Emulate pressing the WiFi tethering button.

        mTethering.startTethering(ConnectivityManager.TETHERING_WIFI, null, false);

        mLooper.dispatchAll();

        verify(mWifiManager, times(1)).setWifiApEnabled(null, true);

        verify(mWifiManager, times(1)).startSoftAp(null);

        verifyNoMoreInteractions(mWifiManager);

        verifyNoMoreInteractions(mConnectivityManager);

        verifyNoMoreInteractions(mNMService);
@@ -286,7 +283,7 @@ public class TetheringTest { 
        // Emulate pressing the WiFi tethering button.

        mTethering.stopTethering(ConnectivityManager.TETHERING_WIFI);

        mLooper.dispatchAll();

        verify(mWifiManager, times(1)).setWifiApEnabled(null, false);

        verify(mWifiManager, times(1)).stopSoftAp();

        verifyNoMoreInteractions(mWifiManager);

        verifyNoMoreInteractions(mConnectivityManager);

        verifyNoMoreInteractions(mNMService);