Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ce0fa6cf authored by Steve Elliott's avatar Steve Elliott
Browse files

[kairos] Fix indirectRoot set change tracking 

We were adding when we should have been removing :-(

Flag: com.android.systemui.status_bar_mobile_icon_kairos
Bug: 383172066
Test: atest
Change-Id: I00ef363a21c188bb6c536102b946f2d4286c6d29
parent e726011b

packages/SystemUI/utils/kairos/src/com/android/systemui/kairos/internal/Graph.kt

+7 −5
Original line number Diff line number Diff line
@@ -166,15 +166,17 @@ internal class DepthTracker { 
        val addsChanged =

            additions

                ?.let { dirty_indirectUpstreamRoots.addAll(additions, butNot) }

                ?.let {

                    indirectAdditions.addAll(indirectRemovals.applyRemovalDiff(it))

                ?.let { newlyAdded ->

                    val remainder = indirectRemovals.applyRemovalDiff(newlyAdded)

                    indirectAdditions.addAll(remainder)

                    true

                } ?: false

        val removalsChanged =

            removals

                ?.let { dirty_indirectUpstreamRoots.removeAll(removals) }

                ?.let {

                    indirectRemovals.addAll(indirectAdditions.applyRemovalDiff(it))

                ?.let { fullyRemoved ->

                    val remainder = indirectAdditions.applyRemovalDiff(fullyRemoved)

                    indirectRemovals.addAll(remainder)

                    true

                } ?: false

        return (!dirty_depthIsDirect && (addsChanged || removalsChanged))
@@ -183,7 +185,7 @@ internal class DepthTracker { 
    private fun <T> HashSet<T>.applyRemovalDiff(changeSet: Set<T>): Set<T> {

        val remainder = HashSet<T>()

        for (element in changeSet) {

            if (!add(element)) {

            if (!remove(element)) {

                remainder.add(element)

            }

        }

packages/SystemUI/utils/kairos/src/com/android/systemui/kairos/internal/util/Bag.kt

+8 −0
Original line number Diff line number Diff line
@@ -51,6 +51,10 @@ internal class Bag<T> private constructor(private val intMap: MutableMap<T, Int> 
        }

    }



    /**

     * Adds all [elements], skipping [butNot], and returns the subset of [elements] that were not

     * already present in this bag.

     */

    fun addAll(elements: Iterable<T>, butNot: T? = null): Set<T>? {

        val newlyAdded = hashSetOf<T>()

        for (value in elements) {
@@ -67,6 +71,10 @@ internal class Bag<T> private constructor(private val intMap: MutableMap<T, Int> 
        intMap.clear()

    }



    /**

     * Removes all [elements], and returns the subset of [elements] that are no longer present in

     * this bag.

     */

    fun removeAll(elements: Collection<T>): Set<T>? {

        val result = hashSetOf<T>()

        for (element in elements) {