Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cdb81670 authored by Adrian Roos's avatar Adrian Roos
Browse files

Apilint: No longer flag interface callbacks 

With default interfaces, this is no longer necessary.

Test: python apilint_test.py
Change-Id: Ifa9ba24511a82797089934009d9096c3a589e7f6
parent 56ff7843

tools/apilint/apilint.py

+0 −4
Original line number Diff line number Diff line
@@ -816,7 +816,6 @@ def verify_method_names(clazz): 


def verify_callbacks(clazz):

    """Verify Callback classes.

    All callback classes must be abstract.

    All methods must follow onFoo() naming style."""

    if clazz.fullname == "android.speech.tts.SynthesisCallback": return
@@ -826,9 +825,6 @@ def verify_callbacks(clazz): 
        warn(clazz, None, "L1", "Class should be named FooCallback")



    if clazz.name.endswith("Callback"):

        if "interface" in clazz.split:

            error(clazz, None, "CL3", "Callbacks must be abstract class to enable extension in future API levels")



        for m in clazz.methods:

            if not re.match("on[A-Z][a-z]*", m.name):

                error(clazz, m, "L1", "Callback method names must be onFoo() style")