Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cda60ac3 authored by Winson Chung's avatar Winson Chung
Browse files

Removing unnecessary code 

- The code was existing before we added onRecentsAnimationStateChanged
  earlier.  But none of the other callers call this method with
  barWindow=NAV_BAR so this code was previously not even getting hit.
  In particular, touchAutoDim is already triggered in the nav bar layout
  touch handling, and the volume panel already listens for touch outside
  so all this does is trigger unnecessary animations (volume
  tries to animate even when not showing, and we don't dim the gesture
  bar since we have the sampling).

Change-Id: I0bb309e1ddb593d01ce8f5fcc9622753324cdd09
parent f277044b

packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBar.java

+0 −6
Original line number Diff line number Diff line
@@ -2477,7 +2477,6 @@ public class StatusBar extends SystemUI implements DemoMode, 
    private final Runnable mCheckBarModes = this::checkBarModes;



    public void setInteracting(int barWindow, boolean interacting) {

        final boolean changing = ((mInteractingWindows & barWindow) != 0) != interacting;

        mInteractingWindows = interacting

                ? (mInteractingWindows | barWindow)

                : (mInteractingWindows & ~barWindow);
@@ -2486,11 +2485,6 @@ public class StatusBar extends SystemUI implements DemoMode, 
        } else {

            mAutoHideController.resumeSuspendedAutoHide();

        }

        // manually dismiss the volume panel when interacting with the nav bar

        if (changing && interacting && barWindow == StatusBarManager.WINDOW_NAVIGATION_BAR) {

            mNavigationBarController.touchAutoDim(mDisplayId);

            dismissVolumeDialog();

        }

        checkBarModes();

    }