Prevent NPE when profile is null (cd9ee08b) · Commits · e / os / android_frameworks_base

packages/SettingsLib/src/com/android/settingslib/bluetooth/CachedBluetoothDevice.java

+13 −2

Original line number	Diff line number	Diff line
		@@ -1189,7 +1189,8 @@ public class CachedBluetoothDevice implements Comparable<CachedBluetoothDevice>
		* @return {@code true} if {@code cachedBluetoothDevice} is a2dp device
		*/
		public boolean isA2dpDevice() {
		return mProfileManager.getA2dpProfile().getConnectionStatus(mDevice) ==
		A2dpProfile a2dpProfile = mProfileManager.getA2dpProfile();
		return a2dpProfile != null && a2dpProfile.getConnectionStatus(mDevice) ==
		BluetoothProfile.STATE_CONNECTED;
		}

		@@ -1197,7 +1198,17 @@ public class CachedBluetoothDevice implements Comparable<CachedBluetoothDevice>
		* @return {@code true} if {@code cachedBluetoothDevice} is HFP device
		*/
		public boolean isHfpDevice() {
		return mProfileManager.getHeadsetProfile().getConnectionStatus(mDevice) ==
		HeadsetProfile headsetProfile = mProfileManager.getHeadsetProfile();
		return headsetProfile != null && headsetProfile.getConnectionStatus(mDevice) ==
		BluetoothProfile.STATE_CONNECTED;
		}

		/**
		* @return {@code true} if {@code cachedBluetoothDevice} is Hearing Aid device
		*/
		public boolean isConnectedHearingAidDevice() {
		HearingAidProfile hearingAidProfile = mProfileManager.getHearingAidProfile();
		return hearingAidProfile != null && hearingAidProfile.getConnectionStatus(mDevice) ==
		BluetoothProfile.STATE_CONNECTED;
		}
		}

+39 −0

Original line number	Diff line number	Diff line
		@@ -572,4 +572,43 @@ public class CachedBluetoothDeviceTest {

		assertThat(mCachedDevice.isHfpDevice()).isFalse();
		}

		@Test
		public void isConnectedHearingAidDevice_connected_returnTrue() {
		when(mProfileManager.getHearingAidProfile()).thenReturn(mHearingAidProfile);
		when(mHearingAidProfile.getConnectionStatus(mDevice)).
		thenReturn(BluetoothProfile.STATE_CONNECTED);

		assertThat(mCachedDevice.isConnectedHearingAidDevice()).isTrue();
		}

		@Test
		public void isConnectedHearingAidDevice_disconnected_returnFalse() {
		when(mProfileManager.getHearingAidProfile()).thenReturn(mHearingAidProfile);
		when(mHearingAidProfile.getConnectionStatus(mDevice)).
		thenReturn(BluetoothProfile.STATE_DISCONNECTED);

		assertThat(mCachedDevice.isConnectedHearingAidDevice()).isFalse();
		}

		@Test
		public void isConnectedHfpDevice_profileIsNull_returnFalse() {
		when(mProfileManager.getHeadsetProfile()).thenReturn(null);

		assertThat(mCachedDevice.isHfpDevice()).isFalse();
		}

		@Test
		public void isConnectedA2dpDevice_profileIsNull_returnFalse() {
		when(mProfileManager.getA2dpProfile()).thenReturn(null);

		assertThat(mCachedDevice.isA2dpDevice()).isFalse();
		}

		@Test
		public void isConnectedHearingAidDevice_profileIsNull_returnFalse() {
		when(mProfileManager.getHearingAidProfile()).thenReturn(null);

		assertThat(mCachedDevice.isConnectedHearingAidDevice()).isFalse();
		}
		}