Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cd59febc authored by Gilles Debunne's avatar Gilles Debunne
Browse files

AIOOB exception fix in TabWidget 

Bug http://code.google.com/p/android/issues/detail?id=15005

The problem was not specific to the legacy theme. The code that first
measure the tab's width with no contraint was incorrectly using the
mImposedTabsWidth array which could not have the right size if a
child was added.

The first measure after a child is added should indeed crash. Could
be investigated. This fix is sure anyway.

Change-Id: I4c0594e92019aabc545619e874bdfd49ce69c90e
parent 7ad9eb69

core/java/android/widget/TabWidget.java

+1 −1
Original line number Diff line number Diff line
@@ -174,8 +174,8 @@ public class TabWidget extends LinearLayout implements OnFocusChangeListener { 
    void measureHorizontal(int widthMeasureSpec, int heightMeasureSpec) {

        // First, measure with no constraint

        final int unspecifiedWidth = MeasureSpec.makeMeasureSpec(0, MeasureSpec.UNSPECIFIED);

        super.measureHorizontal(unspecifiedWidth, heightMeasureSpec);

        mImposedTabsHeight = -1;

        super.measureHorizontal(unspecifiedWidth, heightMeasureSpec);



        int extraWidth = getMeasuredWidth() - MeasureSpec.getSize(widthMeasureSpec);

        if (extraWidth > 0) {