Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cd21376d authored by Michal Brzezinski's avatar Michal Brzezinski
Browse files

Improving comment inside expandWithQs for special split shade case 

Bug: 228796547
Test: just changing comment
Change-Id: I2fe903a81645f46a20f10b7d4fe3a3e4ca0768aa
parent 9b836220

packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelViewController.java

+5 −3
Original line number Original line Diff line number Diff line
@@ -1669,9 +1669,11 @@ public class NotificationPanelViewController extends PanelViewController { 
        if (mShouldUseSplitNotificationShade && isOnKeyguard()) {

        if (mShouldUseSplitNotificationShade && isOnKeyguard()) {

            // It's a special case as this method is likely to not be initiated by finger movement

            // It's a special case as this method is likely to not be initiated by finger movement

            // but rather called from adb shell or accessibility service.

            // but rather called from adb shell or accessibility service.

            // In the future method below could be used for non-split shade as well but currently

            // We're using LockscreenShadeTransitionController because on lockscreen that's the

            // motion in that case looks worse than using flingSettings.

            // source of truth for all shade motion. Not using it would make part of state to be

            // TODO: make below function transitioning smoothly also in portrait with empty target

            // outdated and will cause bugs. Ideally we'd use this controller also for non-split

            // case but currently motion in portrait looks worse than when using flingSettings.

            // TODO: make below function transitioning smoothly also in portrait with null target

            mLockscreenShadeTransitionController.goToLockedShade(

            mLockscreenShadeTransitionController.goToLockedShade(

                    /* expandedView= */null, /* needsQSAnimation= */false);

                    /* expandedView= */null, /* needsQSAnimation= */false);

        } else if (isFullyCollapsed()) {

        } else if (isFullyCollapsed()) {