Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cd139a6d authored by Adrian Roos's avatar Adrian Roos
Browse files

Doze: Fix crash when suppressing pulse 

Fixes a crash due to an overzealous state validation.

Change-Id: I363c13206c890a2be56615663f89d80ac256a991
Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/doze/DozeMachineTest.java
Fixes: 33463320
parent a91407f6

packages/SystemUI/src/com/android/systemui/doze/DozeMachine.java

+2 −1
Original line number Diff line number Diff line
@@ -218,7 +218,8 @@ public class DozeMachine { 
                    Preconditions.checkState(mState == State.DOZE_REQUEST_PULSE);

                    break;

                case DOZE_PULSE_DONE:

                    Preconditions.checkState(mState == State.DOZE_PULSING);

                    Preconditions.checkState(

                            mState == State.DOZE_REQUEST_PULSE || mState == State.DOZE_PULSING);

                    break;

                default:

                    break;

packages/SystemUI/tests/src/com/android/systemui/doze/DozeMachineTest.java

+10 −0
Original line number Diff line number Diff line
@@ -212,6 +212,16 @@ public class DozeMachineTest { 
        mMachine.requestState(DOZE_PULSE_DONE);

    }



    @Test

    @UiThreadTest

    public void testSuppressingPulse_doesntCrash() {

        mMachine.requestState(INITIALIZED);



        mMachine.requestState(DOZE);

        mMachine.requestState(DOZE_REQUEST_PULSE);

        mMachine.requestState(DOZE_PULSE_DONE);

    }



    @Test

    @UiThreadTest

    public void testScreen_offInDoze() {