Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cce970d8 authored by Josh's avatar Josh
Browse files

Update shortcut label for "Open assistant" 

Given that users have the option to set up Google Assistant,
or another assistant service, we use "digital assistant" in
lowercase as a catch-all term in these scenarios.

Fix: 388502407
Flag: com.android.systemui.keyboard_shortcut_helper_shortcut_customizer
Test: Manual - check that string is updated in the UI
Change-Id: Ida06fec635af5cbcd531cea9bf1c213cb66c45ba
parent d2ade5c3

packages/SystemUI/multivalentTests/src/com/android/systemui/keyboard/shortcut/data/source/TestShortcuts.kt

+1 −1
Original line number Diff line number Diff line
@@ -533,7 +533,7 @@ object TestShortcuts { 


    val expectedShortcutCategoriesWithSimpleShortcutCombination =

        listOf(

            simpleShortcutCategory(System, "System apps", "Open assistant"),

            simpleShortcutCategory(System, "System apps", "Open digital assistant"),

            simpleShortcutCategory(System, "System controls", "Go to home screen"),

            simpleShortcutCategory(System, "System apps", "Open settings"),

            simpleShortcutCategory(System, "System controls", "Lock screen"),

packages/SystemUI/res/values/strings.xml

+2 −2
Original line number Diff line number Diff line
@@ -2351,8 +2351,8 @@ 
    <string name="group_system_access_all_apps_search">Open apps list</string>

    <!-- User visible title for the keyboard shortcut that accesses [system] settings. [CHAR LIMIT=70] -->

    <string name="group_system_access_system_settings">Open settings</string>

    <!-- User visible title for the keyboard shortcut that accesses Assistant app. [CHAR LIMIT=70] -->

    <string name="group_system_access_google_assistant">Open assistant</string>

    <!-- User visible title for the keyboard shortcut that accesses the default digital assistant app. [CHAR LIMIT=70] -->

    <string name="group_system_access_google_assistant">Open digital assistant</string>

    <!-- User visible title for the keyboard shortcut that locks screen. [CHAR LIMIT=70] -->

    <string name="group_system_lock_screen">Lock screen</string>

    <!-- User visible title for the keyboard shortcut that pulls up Notes app for quick memo. [CHAR LIMIT=70] -->