Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cbcd9be4 authored by Jake Hamby's avatar Jake Hamby
Browse files

Fix a few more Javadoc typos. 

Change-Id: Id43fe2551ef53c1a0a779c6101ea0bc7c23e1f93
parent 25897169

telephony/java/com/android/internal/telephony/GsmAlphabet.java

+1 −1
Original line number Diff line number Diff line
@@ -319,7 +319,7 @@ public class GsmAlphabet { 


                gsmVal = (0x7f & (pdu[offset + byteOffset] >> shift));



                // if it crosses a byte boundry

                // if it crosses a byte boundary

                if (shift > 1) {

                    // set msb bits to 0

                    gsmVal &= 0x7f >> (shift - 1);

telephony/java/com/android/internal/telephony/IccUtils.java

+4 −2
Original line number Diff line number Diff line
@@ -265,9 +265,11 @@ public class IccUtils { 




    /**

     * Converts a byte array into a String hexidecimal characters

     * Converts a byte array into a String of hexadecimal characters.

     *

     * null returns null

     * @param bytes an array of bytes

     *

     * @return hex string representation of bytes array

     */

    public static String

    bytesToHexString(byte[] bytes) {

telephony/java/com/android/internal/telephony/cdma/SmsMessage.java

+2 −2
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ import static android.telephony.SmsMessage.MessageClass; 
/**

 * TODO(cleanup): internally returning null in many places makes

 * debugging very hard (among many other reasons) and should be made

 * more meaningful (replaced with execptions for example).  Null

 * more meaningful (replaced with exceptions for example).  Null

 * returns should only occur at the very outside of the module/class

 * scope.

 */
@@ -614,7 +614,7 @@ public class SmsMessage extends SmsMessageBase { 
     * incrementing within the range 1..65535 remembering the state

     * via a persistent system property.  (See C.S0015-B, v2.0,

     * 4.3.1.5) Since this routine is expected to be accessed via via

     * binder-call, and hence should be threadsafe, it has been

     * binder-call, and hence should be thread-safe, it has been

     * synchronized.

     */

    private synchronized static int getNextMessageId() {

telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java

+3 −3
Original line number Diff line number Diff line
@@ -403,7 +403,7 @@ public final class BearerData { 
    /**

     * Calculate the message text encoding length, fragmentation, and other details.

     *

     * @param force ignore (but still count) illegal characters if true

     * @param force7BitEncoding ignore (but still count) illegal characters if true

     * @return septet count, or -1 on failure

     */

    public static TextEncodingDetails calcTextEncodingDetails(CharSequence msg,
@@ -693,7 +693,7 @@ public final class BearerData { 
    /*

     * TODO(cleanup): CdmaSmsAddress encoding should make use of

     * CdmaSmsAddress.parse provided that DTMF encoding is unified,

     * and the difference in 4bit vs 8bit is resolved.

     * and the difference in 4-bit vs. 8-bit is resolved.

     */



    private static void encodeCdmaSmsAddress(CdmaSmsAddress addr) throws CodingException {
@@ -912,7 +912,7 @@ public final class BearerData { 
    private static String decodeUtf16(byte[] data, int offset, int numFields)

        throws CodingException

    {

        // Start reading from the next 16-bit aligned boundry after offset.

        // Start reading from the next 16-bit aligned boundary after offset.

        int padding = offset % 2;

        numFields -= (offset + padding) / 2;

        try {

telephony/tests/telephonytests/src/com/android/internal/telephony/GsmAlphabetTest.java

+1 −1
Original line number Diff line number Diff line
@@ -51,7 +51,7 @@ public class GsmAlphabetTest extends TestCase { 
        // '@' maps to char 0

        assertEquals(0, GsmAlphabet.charToGsm('@'));



        // `a (a with grave accent) maps to last GSM charater

        // `a (a with grave accent) maps to last GSM character

        assertEquals(0x7f, GsmAlphabet.charToGsm('\u00e0'));



        //